Summary

Add final stubs for root comment and review resources.

Review Request #14412 — Created April 30, 2025 and submitted May 22, 2025, 4:54 p.m.

Information

Owner

david

Repository

RBTools

Branch

master

Bugs

Depends On

Reviewers

Groups

rbtools

People

Description

We recently added root-level list resources for reviews and comments.
These have the same MIME types as the other review and comment list
resources, and so they can share the same subclasses, but they do have
different GET parameters that support a wider variety of queries. This
change adds params types for these and root resource stubs.

Testing Done


Ran unit tests.
Used these methods from a test script and saw that everything worked

  as expected.

Commits

Summary	ID
Add final stubs for root comment and review resources. We recently added root-level list resources for reviews and comments. These have the same MIME types as the other review and comment list resources, and so they can share the same subclasses, but they do have different GET parameters that support a wider variety of queries. This change adds params types for these and root resource stubs. Testing Done: - Ran unit tests. - Used these methods from a test script and saw that everything worked as expected.	a1c73fae6f46dd8cb104ea02b7497064780a8520

Summary

Add final stubs for root comment and review resources.

We recently added root-level list resources for reviews and comments. These have the same MIME types as the other review and comment list resources, and so they can share the same subclasses, but they do have different GET parameters that support a wider variety of queries. This change adds params types for these and root resource stubs. Testing Done: - Ran unit tests. - Used these methods from a test script and saw that everything worked as expected.

a1c73fae6f46dd8cb104ea02b7497064780a8520

Issues

Description	From	Last Updated
These should say 'file attachment comments' instead of 'diff comments'.	maubin	May 1, 2025, 8:14 a.m.
Here and below should say 'general comment' instead of 'file attachment comment' and 'diff comment'.	maubin	May 1, 2025, 8:15 a.m.
This should be FileAttachmentCommentListResource.	maubin	May 1, 2025, 8:23 a.m.

flake8 passed.

JSHint passed.

rbtools/api/resource/file_attachment_comment.py (Diff revision 1)
The issue has been resolved. Show all issues
```
These should say 'file attachment comments' instead of 'diff comments'.
```

rbtools/api/resource/general_comment.py (Diff revision 1)

The issue has been resolved. Show all issues

Here and below should say 'general comment' instead of 'file attachment comment' and 'diff comment'.

rbtools/api/resource/root.py (Diff revision 1)
The issue has been resolved. Show all issues
```
This should be FileAttachmentCommentListResource.
```

Commits:

	Summary	ID
	Add final stubs for root comment and review resources. We recently added root-level list resources for reviews and comments. These have the same MIME types as the other review and comment list resources, and so they can share the same subclasses, but they do have different GET parameters that support a wider variety of queries. This change adds params types for these and root resource stubs. Testing Done: - Ran unit tests. - Used these methods from a test script and saw that everything worked as expected.	d05dfadac34fd9d68e074ae87c4c2fdae457d4b0
	Add final stubs for root comment and review resources. We recently added root-level list resources for reviews and comments. These have the same MIME types as the other review and comment list resources, and so they can share the same subclasses, but they do have different GET parameters that support a wider variety of queries. This change adds params types for these and root resource stubs. Testing Done: - Ran unit tests. - Used these methods from a test script and saw that everything worked as expected.	a1c73fae6f46dd8cb104ea02b7497064780a8520

Diff:

Revision 2 (+590 -12)

Show changes

	rbtools/api/resource/diff_comment.py
	rbtools/api/resource/file_attachment_comment.py
	rbtools/api/resource/general_comment.py
	rbtools/api/resource/review.py
	rbtools/api/resource/root.py

Checks run (2 succeeded)

flake8 passed.

JSHint passed.

Ship it!

```
Ship It!
```

Ship it!

```
Ship It!
```

Status:: Completed
Change Summary:: Pushed to master (e4e826f)