Handle Windows-style line endings in the TFSClient.

 






 

 


  Review Request #14411
  —
  Created April 29, 2025 and submitted  — Latest diff uploaded 

 


















 

  

   Information

  





 
 

  maubin
 









 
 

  RBTools
 









 
 

  release-5.x
 









 
 

  
 









 
 

  
 






 




 

  

   Reviewers

  





 
 

  rbtools
 









 
 

  
 






 








 





  


 
 

  
There's one area where our TFExeWrapper fails to parse the output from

"tf vc history" due to not properly handling Windows-style line endings

(\r\n). This change fixes that and adds a unit test. The rest of the

TFSClient code was audited to make sure there weren't any other problems

with line endings.

 








  


 
 

  
    

  • Ran unit tests.
    • 

  • Tested rbt post and rbt list-repo-types in a TFS repository on
    
  a Windows machine.
    • 


 







 









 





  








 




 







   

    
    
Diff Revision 2 (Latest)



    

 

 

 

 
orig
1
2

 



    


    

      
Commits

      

 

 

  
   First
   Last
  
  Summary
  ID
  Author
 



 
  
   
  
  
   
  
 
 
  
   
    

     Handle Windows-style line endings in the TFSClient.
     
There's one area where our TFExeWrapper fails to parse the output from
"tf vc history" due to not properly handling Windows-style line endings
(`\r\n`). This change fixes that and adds a unit test. The rest of the
TFSClient code was audited to make sure there weren't any other problems
with line endings.

    

   
  		
  9c95d72553508bde9055cf4720f63cf51fb494cf
  Michelle Aubin
 




    


    
    

   

  

 









 

  

   
    

     
      
      rbtools/clients/tfs.py
     
    

   
  

 



 

  

   
    

     
      
      rbtools/clients/tests/test_tfs.py
     
    

   
  

 










     

    

   

  

  

   
   Loading...