Summary

Handle Windows-style line endings in the TFSClient.

Review Request #14411 — Created April 29, 2025 and submitted May 5, 2025, 9:32 p.m.

Information

Owner

maubin

Repository

RBTools

Branch

release-5.x

Bugs

Depends On

Reviewers

Groups

rbtools

People

Description

There's one area where our TFExeWrapper fails to parse the output from
"tf vc history" due to not properly handling Windows-style line endings
(\r\n). This change fixes that and adds a unit test. The rest of the
TFSClient code was audited to make sure there weren't any other problems
with line endings.

Testing Done


Ran unit tests.
Tested rbt post and rbt list-repo-types in a TFS repository on

  a Windows machine.

Commits

Summary	ID
Handle Windows-style line endings in the TFSClient. There's one area where our TFExeWrapper fails to parse the output from "tf vc history" due to not properly handling Windows-style line endings (`\r\n`). This change fixes that and adds a unit test. The rest of the TFSClient code was audited to make sure there weren't any other problems with line endings.	9c95d72553508bde9055cf4720f63cf51fb494cf

Issues

Description	From	Last Updated
In the description, it should probably be \r\n.	chipx86	April 30, 2025, 2:15 p.m.

flake8 passed.

JSHint passed.

Ship it!

The issue has been resolved. Show all issues
```
In the description, it should probably be \r\n.
```
1. maubin April 30, 2025, 2:15 p.m.
  Oops.

Description:

		There's one area where our TFExeWrapper fails to parse the output from
		"tf vc history" due to not properly handling Windows-style line endings
~		(`/r/n`). This change fixes that and adds a unit test. The rest of the
	~	(`\r\n`). This change fixes that and adds a unit test. The rest of the
		TFSClient code was audited to make sure there weren't any other problems
		with line endings.

Commits:

	Summary	ID
	Handle Windows-style line endings in the TFSClient. There's one area where our TFExeWrapper fails to parse the output from "tf vc history" due to not properly handling Windows-style line endings (`/r/n`). This change fixes that and adds a unit test. The rest of the TFSClient code was audited to make sure there weren't any other problems with line endings.	2c96a9641093704e69fbea75cabadd5201300fb7
	Handle Windows-style line endings in the TFSClient. There's one area where our TFExeWrapper fails to parse the output from "tf vc history" due to not properly handling Windows-style line endings (`\r\n`). This change fixes that and adds a unit test. The rest of the TFSClient code was audited to make sure there weren't any other problems with line endings.	9c95d72553508bde9055cf4720f63cf51fb494cf

Diff:

Revision 2 (+64 -2)

Show changes

	rbtools/clients/tfs.py
	rbtools/clients/tests/test_tfs.py

Checks run (2 succeeded)

flake8 passed.

JSHint passed.

Ship it!

```
Ship It!
```

Status:: Completed
Change Summary:: Pushed to release-5.x (5c83ce0)