Add a setting for controlling whether to confirm a Ship It! review.

Review Request #14409 — Created April 29, 2025 and submitted — Latest diff uploaded

Information

Review Board
release-7.1.x

Reviewers

With the modern location for the Ship It action (in the Review menu),
it's much harder to accidentally post a Ship It review. This makes the
confirmation prompt less important than it once was.

We now have a setting for controlling whether to prompt for
confirmation. This is managed in My Account -> Settings.

The confirmation dialog itself now uses an Ink modal dialog, with some
additional text to help guide users. It also includes a "Do not ask
again" checkbox, which will turn off the confirmation setting as well.
This is a sort of prototype for a suppression dialog that we may want in
Ink.

The setting is managed through the User Session resource, which now
accepts a HTTP PUT with a settings:json JSON Merge Patch of settings.
RB.UserSession provides an endpoint for this as well. These currently
only accept this new confirm_ship_it setting, and they're marked as
for internal use only, but it provides a path for more dynamic settings
down the road.

Python and JavaScript unit tests passed.

Tested the Ship It flow with confirmation turned on and off.

Tested the "Do not ask again" checkbox in the confirmation dialog,
verifying that it turned off the confirmation setting.

Changes between revision 3 and 4

orig
1
2
3
4

Commits

Summary ID Author
Add a setting for controlling whether to confirm a Ship It! review.
With the modern location for the Ship It action (in the Review menu), it's much harder to accidentally post a Ship It review. This makes the confirmation prompt less important than it once was. We now have a setting for controlling whether to prompt for confirmation. This is managed in My Account -> Settings. The confirmation dialog itself now uses an Ink modal dialog, with some additional text to help guide users. It also includes a "Do not ask again" checkbox, which will turn off the confirmation setting as well. This is a sort of prototype for a suppression dialog that we may want in Ink. The setting is managed through the User Session resource, which now accepts a HTTP PUT with a `settings:json` JSON Merge Patch of settings. `RB.UserSession` provides an endpoint for this as well. These currently only accept this new `confirm_ship_it` setting, and they're marked as for internal use only, but it provides a path for more dynamic settings down the road.
7dce65f66f8cbb2fe820baf638abc8efdbc1ee73 Christian Hammond
Add a setting for controlling whether to confirm a Ship It! review.
With the modern location for the Ship It action (in the Review menu), it's much harder to accidentally post a Ship It review. This makes the confirmation prompt less important than it once was. We now have a setting for controlling whether to prompt for confirmation. This is managed in My Account -> Settings. The confirmation dialog itself now uses an Ink modal dialog, with some additional text to help guide users. It also includes a "Do not ask again" checkbox, which will turn off the confirmation setting as well. This is a sort of prototype for a suppression dialog that we may want in Ink. The setting is managed through the User Session resource, which now accepts a HTTP PUT with a `settings:json` JSON Merge Patch of settings. `RB.UserSession` provides an endpoint for this as well. These currently only accept this new `confirm_ship_it` setting, and they're marked as for internal use only, but it provides a path for more dynamic settings down the road.
2c03cc3ba8e0fe231e320cbe120a75a1804668f3 Christian Hammond
reviewboard/accounts/models.py
reviewboard/accounts/forms/pages.py
reviewboard/static/rb/js/common/models/userSessionModel.ts
Loading...