Summary

Allow TFS client to use TFVC's tf.exe from modern versions of Visual Studio.

Review Request #14408 — Created April 29, 2025 and submitted May 16, 2025, 2:51 a.m.

Information

Owner

maubin

Repository

RBTools

Branch

release-5.x

Bugs

Depends On

Reviewers

Groups

rbtools

People

Description

We have multiple wrapper classes for the TFS client which let us fall

back on whatever tools are available on the system (TF, TEE, or TF Helper).

Our TF wrapper checks that we're using the TFVC version from Visual

Studio 2017 (version 15), and blocks all other versions. At the time VS 2017

was the latest version, but now the latest version is Visual Studio

2022, which uses version 17 of TFVC. This change allows us to use any

version of TFVC higher than or equal to 15. This also updates the

documentation accordingly.

Testing Done


Ran unit tests.
Used rbt post to post a change from a TFVC repo using Visual Studio 2022.

Commits

Summary	ID
Allow TFS client to use TFVC's tf.exe from modern versions of Visual Studio. We have multiple wrapper classes for the TFS client which let us fall back on whatever tools are available on the system (TF, TEE, or TF Helper). Our TF wrapper checks that we're using the TFVC version from Visual Studio 2017 (version 15), and blocks all other versions. At the time VS 2017 was the latest version, but now the latest version is Visual Studio 2022, which uses version 17 of TFVC. This change allows us to use any version of TFVC higher than or equal to 15. This also updates the documentation accordingly.	7242a97ac445c1719c56c3dfc9b019916745002a

Summary

Allow TFS client to use TFVC's tf.exe from modern versions of Visual Studio.

We have multiple wrapper classes for the TFS client which let us fall back on whatever tools are available on the system (TF, TEE, or TF Helper). Our TF wrapper checks that we're using the TFVC version from Visual Studio 2017 (version 15), and blocks all other versions. At the time VS 2017 was the latest version, but now the latest version is Visual Studio 2022, which uses version 17 of TFVC. This change allows us to use any version of TFVC higher than or equal to 15. This also updates the documentation accordingly.

7242a97ac445c1719c56c3dfc9b019916745002a

Issues

Description	From	Last Updated
Can you change this to use :command: while here?	chipx86	April 30, 2025, 2:11 p.m.
For new tests, let's start using -> None to opt into type hints, and add an annotations future import at …	chipx86	April 30, 2025, 2:11 p.m.
Should probably be "include" instead of "includes" now.	david	May 5, 2025, 9:48 p.m.

flake8 passed.

JSHint passed.

docs/rbtools/rbt/configuration/tfs.rst (Diff revision 1)
The issue has been resolved. Show all issues
```
Can you change this to use :command: while here?
```

rbtools/clients/tests/test_tfs.py (Diff revision 1)

The issue has been resolved. Show all issues

For new tests, let's start using -> None to opt into type hints, and add an annotations future import at the top. We can safely go with type hints for all Power Pack code now.

Commits:

	Summary	ID
	Allow TFS client to use TFVC's tf.exe from modern versions of Visual Studio. We have multiple wrapper classes for the TFS client which let us fall back on whatever tools are available on the system (TF, TEE, or TF Helper). Our TF wrapper checks that we're using the TFVC version from Visual Studio 2017 (version 15), and blocks all other versions. At the time VS 2017 was the latest version, but now the latest version is Visual Studio 2022, which uses version 17 of TFVC. This change allows us to use any version of TFVC higher than or equal to 15. This also updates the documentation accordingly.	c648e4516719a8e6f8ed1b351461eefdb7dd93f1
	Allow TFS client to use TFVC's tf.exe from modern versions of Visual Studio. We have multiple wrapper classes for the TFS client which let us fall back on whatever tools are available on the system (TF, TEE, or TF Helper). Our TF wrapper checks that we're using the TFVC version from Visual Studio 2017 (version 15), and blocks all other versions. At the time VS 2017 was the latest version, but now the latest version is Visual Studio 2022, which uses version 17 of TFVC. This change allows us to use any version of TFVC higher than or equal to 15. This also updates the documentation accordingly.	d7431b13dc4d07f09049bea197686cde5128abda

Diff:

Revision 2 (+160 -64)

Show changes

	docs/rbtools/rbt/configuration/tfs.rst
	rbtools/clients/tfs.py
	rbtools/clients/tests/test_tfs.py

Checks run (2 succeeded)

flake8 passed.

JSHint passed.

Ship it!

docs/rbtools/rbt/configuration/tfs.rst (Diff revision 2)
The issue has been resolved. Show all issues
```
Should probably be "include" instead of "includes" now.
```

Commits:

	Summary	ID
	Allow TFS client to use TFVC's tf.exe from modern versions of Visual Studio. We have multiple wrapper classes for the TFS client which let us fall back on whatever tools are available on the system (TF, TEE, or TF Helper). Our TF wrapper checks that we're using the TFVC version from Visual Studio 2017 (version 15), and blocks all other versions. At the time VS 2017 was the latest version, but now the latest version is Visual Studio 2022, which uses version 17 of TFVC. This change allows us to use any version of TFVC higher than or equal to 15. This also updates the documentation accordingly.	d7431b13dc4d07f09049bea197686cde5128abda
	Allow TFS client to use TFVC's tf.exe from modern versions of Visual Studio. We have multiple wrapper classes for the TFS client which let us fall back on whatever tools are available on the system (TF, TEE, or TF Helper). Our TF wrapper checks that we're using the TFVC version from Visual Studio 2017 (version 15), and blocks all other versions. At the time VS 2017 was the latest version, but now the latest version is Visual Studio 2022, which uses version 17 of TFVC. This change allows us to use any version of TFVC higher than or equal to 15. This also updates the documentation accordingly.	7242a97ac445c1719c56c3dfc9b019916745002a

Diff:

Revision 3 (+160 -64)

Show changes

	docs/rbtools/rbt/configuration/tfs.rst
	rbtools/clients/tfs.py
	rbtools/clients/tests/test_tfs.py

Checks run (2 succeeded)

flake8 passed.

JSHint passed.

Ship it!

```
Ship It!
```

Ship it!

```
Ship It!
```

Status:: Completed
Change Summary:: Pushed to release-5.x (4782635)