Allow users to say "Ship It!" to their own review requests by default.

Review Request #14402 — Created April 23, 2025 and submitted — Latest diff uploaded

Information

Review Board
release-7.1.x

Reviewers

In RB 7.1 we added a setting to disallow users from saying "Ship It!" to
their own review requests. By default we had set this to disallow
because it makes sense that users shouldn't approve their own changes.
However, its a noticeable change from what we had before and I think
it'll surprise existing users too much. I myself got confused and wondered
where the Ship It! button went. This change enables this setting by default.

  • Ran unit tests.
  • Toggled the setting and saw that I couldn't self ship-it when disabled,
    saw that I could when enabled.

Diff Revision 1 (Latest)

Commits

First Last Summary ID Author
Allow users to say "Ship It!" to their own review requests by default.
In RB 7.1 we added a setting to disallow users from saying "Ship It!" to their own review requests. By default we had set this to disallow because it makes sense and is reasonable in practice. However, its a noticeable change from what we had before and I think it'll surprise existing users too much. I myself got confused and wondered where the ship it button went. This change enables this setting by default.
1d078ef334c2a42da30d2aec8919018d8f35d6af Michelle Aubin
reviewboard/accounts/tests/test_template_tags.py
reviewboard/admin/siteconfig.py
reviewboard/reviews/tests/test_actions.py
reviewboard/static/rb/js/common/models/userSessionModel.ts
Loading...