Wrap git invocations in `with`.

 






 

 


  Review Request #14400
  —
  Created April 14, 2025 and submitted  — Latest diff uploaded 

 


















 

  

   Information

  





 
 

  david
 









 
 

  Review Board
 









 
 

  master
 









 
 

  
 









 
 

  
 






 




 

  

   Reviewers

  





 
 

  reviewboard
 









 
 

  
 






 








 





  


 
 

  
Running with the latest Python, I was getting warnings about leaked file

descriptors, which were coming from git invocations inside the

GitClient, as it created BufferedReader instances for stdout/stderr.

This change wraps those subprocess invocations in with blocks, causing

things to get cleaned up appropriately.

 








  


 
 

  
Loaded some diffs and no longer saw warnings about leaked resources.

 







 









 





  








 




 







   

    
    

    

    


    

      
Commits

      

        
      

    


    


      
Files