This change has been marked as completed.

Describe the completed change (optional):

Summary

Fix showing output for non-sortable sets of values.

Review Request #14386 — Created March 21, 2025 and submitted 3 weeks, 5 days ago

Information

Owner

chipx86*

Repository

django-assert-queries

Branch

main

Bugs

Depends On

Reviewers

Groups

beanbag-misc

People

Description*

When showing output from a failed comparison where sets are involved, we
try to sort the values to provide consistent odering for comparison.
When doing this, we could hit an error saying that the values aren't
sortable, due to __lt__ not being implemented.

We now detect this case and sort by the representations of the values
instead.

Testing Done

All unit tests pass.

Verified this fixed issues encountered in some new unit tests in
Review Board.

Commits

Summary	ID
Fix showing output for non-sortable sets of values. When showing output from a failed comparison where sets are involved, we try to sort the values to provide consistent odering for comparison. When doing this, we could hit an error saying that the values aren't sortable, due to `__lt__` not being implemented. We now detect this case and sort by the representations of the values instead.	b8c5cddf83ebbeee54797c732c33562fbfbf5431

Issues

Description	From	Last Updated
local variable 'obj1' is assigned to but never used Column: 9 Error code: F841	reviewbot	1 month ago
local variable 'obj2' is assigned to but never used Column: 9 Error code: F841	reviewbot	1 month ago
There are no open issues

flake8 failed.

JSHint passed.

flake8

django_assert_queries/tests/test_query_comparator.py (Diff revision 1)
The issue has been resolved. Show all issues
```
local variable 'obj1' is assigned to but never used

Column: 9
Error code: F841
```
django_assert_queries/tests/test_query_comparator.py (Diff revision 1)
The issue has been resolved. Show all issues
```
local variable 'obj2' is assigned to but never used

Column: 9
Error code: F841
```

Change Summary:

Removed unused variables.

Commits:

	Summary	ID
	Fix showing output for non-sortable sets of values. When showing output from a failed comparison where sets are involved, we try to sort the values to provide consistent odering for comparison. When doing this, we could hit an error saying that the values aren't sortable, due to `__lt__` not being implemented. We now detect this case and sort by the representations of the values instead.	e4eec708c1f93d988dfd6e3470fb8de26845462b
	Fix showing output for non-sortable sets of values. When showing output from a failed comparison where sets are involved, we try to sort the values to provide consistent odering for comparison. When doing this, we could hit an error saying that the values aren't sortable, due to `__lt__` not being implemented. We now detect this case and sort by the representations of the values instead.	b8c5cddf83ebbeee54797c732c33562fbfbf5431

Diff:

Revision 2 (+52 -2)

Show changes

	django_assert_queries/query_comparator.py
	django_assert_queries/tests/test_query_comparator.py

Checks run (2 succeeded)

flake8 passed.

JSHint passed.

Ship it!

```
Ship It!
```

Ship it!

```
Ship It!
```

Status:: Completed