Fix comparison to check for identical instances.

 






 

 


  Review Request #14385
  —
  Created March 20, 2025 and submitted  — Latest diff uploaded 

 


















 

  

   Information

  





 
 

  chipx86
 









 
 

  django-assert-queries
 









 
 

  main
 









 
 

  
 









 
 

  
 






 




 

  

   Reviewers

  





 
 

  beanbag-misc
 









 
 

  
 






 








 





  


 
 

  
The model proxies used for deleted object comparisons resulted in a

regression where two references to the same instance weren't guaranteed

to be considered equal.


We now check that the two objects being compared are the same instance

before going into more elaborate checks.

 








  


 
 

  
Unit tests pass in django-assert-queries, Djblets, and Review Board.

 







 









 





  








 




 







   

    
    
Diff Revision 1 (Latest)



    

    


    

      
Commits

      

 

 

  
   First
   Last
  
  Summary
  ID
  Author
 



 
  
   
  
  
   
  
 
 
  
   
    

     Fix comparison to check for identical instances.
     
The model proxies used for deleted object comparisons resulted in a
regression where two references to the same instance weren't guaranteed
to be considered equal.

We now check that the two objects being compared are the same instance
before going into more elaborate checks.

    

   
  		
  ef6493a7986fbee0967a637b58c94531edc87053
  Christian Hammond
 




    


    
    

   

  

 









 

  

   
    

     
      
      django_assert_queries/query_comparator.py
     
    

   
  

 










     

    

   

  

  

   
   Loading...