Fix imports for legacy condition support.

Review Request #14383 — Created March 20, 2025 and updated

Information

rbintegrations
release-4.x

Reviewers

The recent work on extensible condition support in rbintegrations
introduced a backwards-compatible implementation for earlier versions of
Review Board, but this ended up introducing an import that wasn't
present in that module on older versions.

That import was only needed for type hints anyway, so it's been moved
out into a TYPE_CHECKING block and updated to use the correct module
and class for the supported releases.

Tested on Review Board 7.0.2, and verified I no longer hit import errors.

Summary ID
Fix imports for legacy condition support.
The recent work on extensible condition support in rbintegrations introduced a backwards-compatible implementation for earlier versions of Review Board, but this ended up introducing an import that wasn't present in that module on older versions. That import was only needed for type hints anyway, so it's been moved out into a `TYPE_CHECKING` block and updated to use the correct module and class for the supported releases.
51b0aae4875f7236efde8b6d976e1d097819e7a6
Checks run (2 succeeded)
flake8 passed.
JSHint passed.
david
  1. Ship It!
  2. 
      
Loading...