Summary

Add new resources, part 6/7.

Review Request #14379 — Created March 20, 2025 and updated 2 weeks, 5 days ago

Information

Owner

david*

Repository

RBTools

Branch

master

Bugs

Depends On

Reviewers

Groups

rbtools

People

Description*

This change adds the following new resource implementations:
- APITokenItemResource
- APITokenListResource
- HostingServiceAccountItemResource
- HostingServiceAccountListResource
- HostingServiceItemResource
- HostingServiceListResource
- PlainTextResource (used for original/patched files)
- RemoteRepositoryItemResource
- RemoteRepositoryListResource
- SearchResource
- SessionResource

Testing Done


Ran unit tests.
Used the new resources from a test script and saw that everything

  worked as expected.

Commits

Summary	ID
Add new resources, part 6/7. This change adds the following new resource implementations: - APITokenItemResource - APITokenListResource - HostingServiceAccountItemResource - HostingServiceAccountListResource - HostingServiceItemResource - HostingServiceListResource - PlainTextResource (used for original/patched files) - RemoteRepositoryItemResource - RemoteRepositoryListResource - SearchResource - SessionResource Testing Done: - Ran unit tests. - Used the new resources from a test script and saw that everything worked as expected.	34900ae82c7c7f78221548a959d6c6e3f9c353d6

Summary

Add new resources, part 6/7.

This change adds the following new resource implementations: - APITokenItemResource - APITokenListResource - HostingServiceAccountItemResource - HostingServiceAccountListResource - HostingServiceItemResource - HostingServiceListResource - PlainTextResource (used for original/patched files) - RemoteRepositoryItemResource - RemoteRepositoryListResource - SearchResource - SessionResource Testing Done: - Ran unit tests. - Used the new resources from a test script and saw that everything worked as expected.

34900ae82c7c7f78221548a959d6c6e3f9c353d6

Issues

Description	From	Last Updated
I feel like we should explain why this may be None.	chipx86	2 weeks, 6 days ago
I think this should be "... are supported" or something. "available" may indicate presence.	chipx86	2 weeks, 6 days ago
Missing period.	chipx86	2 weeks, 6 days ago
Maybe say "from a diff" so it's clear this isn't a file attachment or in a repository. Same below.	chipx86	2 weeks, 6 days ago
We should specify the version range. Same below.	chipx86	2 weeks, 6 days ago
Should say "List resource"	maubin	2 weeks, 5 days ago
There are no open issues

flake8 passed.

JSHint passed.

rbtools/api/resource/api_token.py (Diff revision 1)
The issue has been resolved. Show all issues
```
I feel like we should explain why this may be None.
```

rbtools/api/resource/hosting_service.py (Diff revision 1)

The issue has been resolved. Show all issues

I think this should be "... are supported" or something. "available" may indicate presence.

rbtools/api/resource/hosting_service_account.py (Diff revision 1)
The issue has been resolved. Show all issues
```
Missing period.
```

rbtools/api/resource/root.py (Diff revision 1)

The issue has been resolved. Show all issues

Maybe say "from a diff" so it's clear this isn't a file attachment or in a repository.

Same below.

rbtools/api/resource/root.py (Diff revision 1)
The issue has been resolved. Show all issues
```
We should specify the version range. Same below.
```

Commits:

	Summary	ID
	Add new resources, part 6/7. This change adds the following new resource implementations: - APITokenItemResource - APITokenListResource - HostingServiceAccountItemResource - HostingServiceAccountListResource - HostingServiceItemResource - HostingServiceListResource - PlainTextResource (used for original/patched files) - RemoteRepositoryItemResource - RemoteRepositoryListResource - SearchResource - SessionResource Testing Done: - Ran unit tests. - Used the new resources from a test script and saw that everything worked as expected.	282fa71cadbe8587aaa0e5629a14a0a3ddad167e
	Add new resources, part 6/7. This change adds the following new resource implementations: - APITokenItemResource - APITokenListResource - HostingServiceAccountItemResource - HostingServiceAccountListResource - HostingServiceItemResource - HostingServiceListResource - PlainTextResource (used for original/patched files) - RemoteRepositoryItemResource - RemoteRepositoryListResource - SearchResource - SessionResource Testing Done: - Ran unit tests. - Used the new resources from a test script and saw that everything worked as expected.	e64bf637faca1caf26804a0cb9c3f6f6e1c6034d

Diff:

Revision 2 (+2254 -8)

Show changes

	rbtools/api/resource/__init__.py
	rbtools/api/resource/api_token.py
	rbtools/api/resource/file_diff.py
	rbtools/api/resource/hosting_service.py
	rbtools/api/resource/hosting_service_account.py
	rbtools/api/resource/plain_text.py
	rbtools/api/resource/remote_repository.py
	rbtools/api/resource/root.py
	3 more

Checks run (2 succeeded)

flake8 passed.

JSHint passed.

Ship it!

rbtools/api/resource/hosting_service_account.py (Diff revision 2)
The issue has been resolved. Show all issues
```
Should say "List resource"
```

Commits:

	Summary	ID
	Add new resources, part 6/7. This change adds the following new resource implementations: - APITokenItemResource - APITokenListResource - HostingServiceAccountItemResource - HostingServiceAccountListResource - HostingServiceItemResource - HostingServiceListResource - PlainTextResource (used for original/patched files) - RemoteRepositoryItemResource - RemoteRepositoryListResource - SearchResource - SessionResource Testing Done: - Ran unit tests. - Used the new resources from a test script and saw that everything worked as expected.	e64bf637faca1caf26804a0cb9c3f6f6e1c6034d
	Add new resources, part 6/7. This change adds the following new resource implementations: - APITokenItemResource - APITokenListResource - HostingServiceAccountItemResource - HostingServiceAccountListResource - HostingServiceItemResource - HostingServiceListResource - PlainTextResource (used for original/patched files) - RemoteRepositoryItemResource - RemoteRepositoryListResource - SearchResource - SessionResource Testing Done: - Ran unit tests. - Used the new resources from a test script and saw that everything worked as expected.	34900ae82c7c7f78221548a959d6c6e3f9c353d6

Diff:

Revision 3 (+2254 -8)

Show changes

	rbtools/api/resource/__init__.py
	rbtools/api/resource/api_token.py
	rbtools/api/resource/file_diff.py
	rbtools/api/resource/hosting_service.py
	rbtools/api/resource/hosting_service_account.py
	rbtools/api/resource/plain_text.py
	rbtools/api/resource/remote_repository.py
	rbtools/api/resource/root.py
	3 more

Checks run (2 succeeded)

flake8 passed.

JSHint passed.