Summary

Add new resources, part 5/7.

Review Request #14378 — Created March 20, 2025 and submitted April 30, 2025, 4:06 p.m.

Information

Owner

david

Repository

RBTools

Branch

master

Bugs

Depends On

Reviewers

Groups

rbtools

People

Description

This change adds the following new resource implementations:
- OAuthApplicationItemResource
- OAuthApplicationListResource
- OAuthTokenItemResource
- OAuthTokenListResource
- ServerInfoResource
- WatchedResource
- WatchedReviewGroupItemResource
- WatchedReviewGroupListResource
- WatchedReviewRequestItemResource
- WatchedReviewRequestListResource
- WebHookItemResource
- WebHookListResource

Testing Done


Ran unit tests.
Used the new resources from a test script and saw that everything

  worked as expected.

Commits

Summary	ID
Add new resources, part 5/7. This change adds the following new resource implementations: - OAuthApplicationItemResource - OAuthApplicationListResource - OAuthTokenItemResource - OAuthTokenListResource - ServerInfoResource - WatchedResource - WatchedReviewGroupItemResource - WatchedReviewGroupListResource - WatchedReviewRequestItemResource - WatchedReviewRequestListResource - WebHookItemResource - WebHookListResource Testing Done: - Ran unit tests. - Used the new resources from a test script and saw that everything worked as expected.	1e7da0cae6b52add5a122af1794406a87a7b0be7

Summary

Add new resources, part 5/7.

This change adds the following new resource implementations: - OAuthApplicationItemResource - OAuthApplicationListResource - OAuthTokenItemResource - OAuthTokenListResource - ServerInfoResource - WatchedResource - WatchedReviewGroupItemResource - WatchedReviewGroupListResource - WatchedReviewRequestItemResource - WatchedReviewRequestListResource - WebHookItemResource - WebHookListResource Testing Done: - Ran unit tests. - Used the new resources from a test script and saw that everything worked as expected.

1e7da0cae6b52add5a122af1794406a87a7b0be7

Issues

Description	From	Last Updated
line too long (85 > 79 characters) Column: 80 Error code: E501	reviewbot	March 20, 2025, 5:08 p.m.
I think this line needs more explanation. Also probably missing "the".	chipx86	April 1, 2025, 3:22 p.m.
Can we specify the format for this value?	chipx86	April 1, 2025, 3:27 p.m.
Missing period.	chipx86	April 1, 2025, 3:28 p.m.
We use "WebHook" elsewhere. Many of these docs use "webhook" though. We should make these consistent with the former.	chipx86	April 1, 2025, 3:28 p.m.
The second #: sould be removed. Also, we should :py:attr: the repositories reference.	chipx86	April 1, 2025, 3:28 p.m.
It'd be nice for these to look like a standard list, for maintainability and readability. For example: encoding: Literal[ 'application/json', …	chipx86	April 1, 2025, 3:28 p.m.
Might be more appropriate to :py:attr:client_secret instead of double backtick?	maubin	April 2, 2025, 12:05 a.m.
Should be WatchedReviewGroupListResource here.	maubin	April 2, 2025, 12:05 a.m.

flake8 failed.

JSHint passed.

flake8

rbtools/api/resource/root.py (Diff revision 1)
The issue has been dropped. Show all issues
```
line too long (85 > 79 characters)

Column: 80
Error code: E501
```

Commits:

	Summary	ID
	Add new resources, part 5/7. This change adds the following new resource implementations: - OAuthApplicationItemResource - OAuthApplicationListResource - OAuthTokenItemResource - OAuthTokenListResource - ServerInfoResource - WatchedResource - WatchedReviewGroupItemResource - WatchedReviewGroupListResource - WatchedReviewRequestItemResource - WatchedReviewRequestListResource - WebHookItemResource - WebHookListResource Testing Done: - Ran unit tests. - Used the new resources from a test script and saw that everything worked as expected.	bb25d1656189c97089cf65395be460523561b476
	Add new resources, part 5/7. This change adds the following new resource implementations: - OAuthApplicationItemResource - OAuthApplicationListResource - OAuthTokenItemResource - OAuthTokenListResource - ServerInfoResource - WatchedResource - WatchedReviewGroupItemResource - WatchedReviewGroupListResource - WatchedReviewRequestItemResource - WatchedReviewRequestListResource - WebHookItemResource - WebHookListResource Testing Done: - Ran unit tests. - Used the new resources from a test script and saw that everything worked as expected.	3346787c118a10e6fd8fbbcb472f09f4b398eacc

Diff:

Revision 2 (+1686 -12)

Show changes

	rbtools/api/resource/__init__.py
	rbtools/api/resource/oauth_application.py
	rbtools/api/resource/oauth_token.py
	rbtools/api/resource/root.py
	rbtools/api/resource/server_info.py
	rbtools/api/resource/user.py
	rbtools/api/resource/watched.py
	rbtools/api/resource/watched_review_group.py
	2 more

Checks run (2 succeeded)

flake8 passed.

JSHint passed.

rbtools/api/resource/oauth_application.py (Diff revision 2)
The issue has been resolved. Show all issues
```
I think this line needs more explanation. Also probably missing "the".
```
rbtools/api/resource/oauth_token.py (Diff revision 2)
The issue has been resolved. Show all issues
```
Can we specify the format for this value?
```
rbtools/api/resource/webhook.py (Diff revision 2)
The issue has been resolved. Show all issues
```
Missing period.
```

rbtools/api/resource/webhook.py (Diff revision 2)

The issue has been resolved. Show all issues

We use "WebHook" elsewhere. Many of these docs use "webhook" though. We should make these consistent with the former.

rbtools/api/resource/webhook.py (Diff revision 2)

The issue has been resolved. Show all issues

The second #: sould be removed.

Also, we should :py:attr: the repositories reference.

rbtools/api/resource/webhook.py (Diff revision 2)

The issue has been resolved. Show all issues

It'd be nice for these to look like a standard list, for maintainability and readability. For example:

encoding: Literal[
    'application/json',
    'application/xml',
    'application/x-www-form-urlencoded',
]

Commits:

	Summary	ID
	Add new resources, part 5/7. This change adds the following new resource implementations: - OAuthApplicationItemResource - OAuthApplicationListResource - OAuthTokenItemResource - OAuthTokenListResource - ServerInfoResource - WatchedResource - WatchedReviewGroupItemResource - WatchedReviewGroupListResource - WatchedReviewRequestItemResource - WatchedReviewRequestListResource - WebHookItemResource - WebHookListResource Testing Done: - Ran unit tests. - Used the new resources from a test script and saw that everything worked as expected.	3346787c118a10e6fd8fbbcb472f09f4b398eacc
	Add new resources, part 5/7. This change adds the following new resource implementations: - OAuthApplicationItemResource - OAuthApplicationListResource - OAuthTokenItemResource - OAuthTokenListResource - ServerInfoResource - WatchedResource - WatchedReviewGroupItemResource - WatchedReviewGroupListResource - WatchedReviewRequestItemResource - WatchedReviewRequestListResource - WebHookItemResource - WebHookListResource Testing Done: - Ran unit tests. - Used the new resources from a test script and saw that everything worked as expected.	9a1877eb22fdac87948a316c08eafcd0d754b1c8

Diff:

Revision 3 (+1700 -12)

Show changes

	rbtools/api/resource/__init__.py
	rbtools/api/resource/oauth_application.py
	rbtools/api/resource/oauth_token.py
	rbtools/api/resource/root.py
	rbtools/api/resource/server_info.py
	rbtools/api/resource/user.py
	rbtools/api/resource/watched.py
	rbtools/api/resource/watched_review_group.py
	2 more

Checks run (2 succeeded)

flake8 passed.

JSHint passed.

rbtools/api/resource/oauth_application.py (Diff revision 3)
The issue has been resolved. Show all issues
```
Might be more appropriate to :py:attr:client_secret instead of double backtick?
```
rbtools/api/resource/watched.py (Diff revision 3)
The issue has been resolved. Show all issues
```
Should be WatchedReviewGroupListResource here.
```

Commits:

	Summary	ID
	Add new resources, part 5/7. This change adds the following new resource implementations: - OAuthApplicationItemResource - OAuthApplicationListResource - OAuthTokenItemResource - OAuthTokenListResource - ServerInfoResource - WatchedResource - WatchedReviewGroupItemResource - WatchedReviewGroupListResource - WatchedReviewRequestItemResource - WatchedReviewRequestListResource - WebHookItemResource - WebHookListResource Testing Done: - Ran unit tests. - Used the new resources from a test script and saw that everything worked as expected.	9a1877eb22fdac87948a316c08eafcd0d754b1c8
	Add new resources, part 5/7. This change adds the following new resource implementations: - OAuthApplicationItemResource - OAuthApplicationListResource - OAuthTokenItemResource - OAuthTokenListResource - ServerInfoResource - WatchedResource - WatchedReviewGroupItemResource - WatchedReviewGroupListResource - WatchedReviewRequestItemResource - WatchedReviewRequestListResource - WebHookItemResource - WebHookListResource Testing Done: - Ran unit tests. - Used the new resources from a test script and saw that everything worked as expected.	1e7da0cae6b52add5a122af1794406a87a7b0be7

Diff:

Revision 4 (+1700 -12)

Show changes

	rbtools/api/resource/__init__.py
	rbtools/api/resource/oauth_application.py
	rbtools/api/resource/oauth_token.py
	rbtools/api/resource/root.py
	rbtools/api/resource/server_info.py
	rbtools/api/resource/user.py
	rbtools/api/resource/watched.py
	rbtools/api/resource/watched_review_group.py
	2 more

Checks run (2 succeeded)

flake8 passed.

JSHint passed.

Ship it!

```
Ship It!
```

Ship it!

```
Ship It!
```

Status:: Completed
Change Summary:: Pushed to master (5b5e323)