Summary

Add new resources, part 4/7.

Review Request #14377 — Created March 20, 2025 and updated 1 day, 14 hours ago

Information

Owner

david*

Repository

RBTools

Branch

master

Bugs

Depends On

Reviewers

Groups

rbtools

People

Description*

This change adds the following new resource implementations:
- DiffCommentItemResource
- DiffCommentListResource
- GeneralCommentItemResource
- GeneralCommentListResource
- ReviewItemResource
- ReviewListResource
- ReviewReplyItemResource
- ReviewReplyListResource
- ScreenshotCommentItemResource
- ScreenshotCommentListResource

Testing Done


Ran unit tests.
Used the new resources from a test script and saw that everything

  worked as expected.

Commits

Summary	ID
Add new resources, part 4/7. This change adds the following new resource implementations: - DiffCommentItemResource - DiffCommentListResource - GeneralCommentItemResource - GeneralCommentListResource - ReviewItemResource - ReviewListResource - ReviewReplyItemResource - ReviewReplyListResource - ScreenshotCommentItemResource - ScreenshotCommentListResource Testing Done: - Ran unit tests. - Used the new resources from a test script and saw that everything worked as expected.	94851572f3f4d2c91b7a638332db91d467f5cd81

Summary

Add new resources, part 4/7.

This change adds the following new resource implementations: - DiffCommentItemResource - DiffCommentListResource - GeneralCommentItemResource - GeneralCommentListResource - ReviewItemResource - ReviewListResource - ReviewReplyItemResource - ReviewReplyListResource - ScreenshotCommentItemResource - ScreenshotCommentListResource Testing Done: - Ran unit tests. - Used the new resources from a test script and saw that everything worked as expected.

94851572f3f4d2c91b7a638332db91d467f5cd81

Issues

Description	From	Last Updated
too many blank lines (2) Column: 5 Error code: E303	reviewbot	1 day, 14 hours ago
blank line at end of file Column: 1 Error code: W391	reviewbot	1 day, 14 hours ago
There are no open issues

flake8 failed.

JSHint passed.

flake8

rbtools/api/resource/diff_comment.py (Diff revision 1)
The issue has been resolved. Show all issues
```
too many blank lines (2)

Column: 5
Error code: E303
```
rbtools/api/resource/screenshot_comment.py (Diff revision 1)
The issue has been resolved. Show all issues
```
blank line at end of file

Column: 1
Error code: W391
```

Commits:

	Summary	ID
	Add new resources, part 4/7. This change adds the following new resource implementations: - DiffCommentItemResource - DiffCommentListResource - GeneralCommentItemResource - GeneralCommentListResource - ReviewItemResource - ReviewListResource - ReviewReplyItemResource - ReviewReplyListResource - ScreenshotCommentItemResource - ScreenshotCommentListResource Testing Done: - Ran unit tests. - Used the new resources from a test script and saw that everything worked as expected.	6a041c1f0a2bc870ac34a3f681abd66d66502d89
	Add new resources, part 4/7. This change adds the following new resource implementations: - DiffCommentItemResource - DiffCommentListResource - GeneralCommentItemResource - GeneralCommentListResource - ReviewItemResource - ReviewListResource - ReviewReplyItemResource - ReviewReplyListResource - ScreenshotCommentItemResource - ScreenshotCommentListResource Testing Done: - Ran unit tests. - Used the new resources from a test script and saw that everything worked as expected.	94851572f3f4d2c91b7a638332db91d467f5cd81

Diff:

Revision 2 (+4174 -16)

Show changes

	rbtools/api/resource/__init__.py
	rbtools/api/resource/base_comment.py
	rbtools/api/resource/base_review.py
	rbtools/api/resource/diff_comment.py
	rbtools/api/resource/file_attachment.py
	rbtools/api/resource/file_attachment_comment.py
	rbtools/api/resource/file_diff.py
	rbtools/api/resource/general_comment.py
	7 more

Checks run (2 succeeded)

flake8 passed.

JSHint passed.