Summary

Add log timers around all communication over Celery.

Review Request #14373 — Created March 18, 2025 and updated 1 day, 23 hours ago

Information

Owner

chipx86*

Repository

ReviewBot

Branch

release-4.x

Bugs

Depends On

Reviewers

Groups

reviewbot

People

Description*

As this utilizes new functionality in Djblets 5.3 / Review Board 7.0.1,
we're including a backport of the modern log_timed(). This will be
removed when we can depend on newer releases.

Testing Done

Tested worker status refreshes, tool refreshes, automatic tool runs,
and manual tool runs. All provided the correct logging information.

Unit tests pass.

Commits

Summary	ID
Add log timers around all communication over Celery. In order to help debug networking-related problems, we now include log timers around all outgoing requests to Celery. This includes task runs and tool refreshes. These are DEBUG-logged unless timing exceeds a threshold, helping to catch delayed requests. As this utilizes new functionality in Djblets 5.3 / Review Board 7.0.1, we're including a backport of the modern `log_timed()`. This will be removed when we can depend on newer releases.	839f20a186152d9427d7e714af409a3fa7e921cf

Summary

Add log timers around all communication over Celery.

In order to help debug networking-related problems, we now include log timers around all outgoing requests to Celery. This includes task runs and tool refreshes. These are DEBUG-logged unless timing exceeds a threshold, helping to catch delayed requests. As this utilizes new functionality in Djblets 5.3 / Review Board 7.0.1, we're including a backport of the modern `log_timed()`. This will be removed when we can depend on newer releases.

839f20a186152d9427d7e714af409a3fa7e921cf

Issues

Description	From	Last Updated
f-string is missing placeholders Column: 24 Error code: F541	reviewbot	3 days, 15 hours ago
f-string is missing placeholders Column: 32 Error code: F541	reviewbot	3 days, 15 hours ago
Shouldn't this be 4.0.1? Same elsewhere in this change.	david	2 days, 10 hours ago
These look like they were copy/pasted from djblets. I don't think we need the version info here at all.	david	1 day, 23 hours ago

flake8 failed.

JSHint passed.

flake8

extension/reviewbotext/extension.py (Diff revision 1)
The issue has been resolved. Show all issues
```
f-string is missing placeholders

Column: 24
Error code: F541
```
extension/reviewbotext/views.py (Diff revision 1)
The issue has been resolved. Show all issues
```
f-string is missing placeholders

Column: 32
Error code: F541
```

Change Summary:

Turned two f-strings back into normal strings.

Commits:

	Summary	ID
	Add log timers around all communication over Celery. In order to help debug networking-related problems, we now include log timers around all outgoing requests to Celery. This includes task runs and tool refreshes. These are DEBUG-logged unless timing exceeds a threshold, helping to catch delayed requests. As this utilizes new functionality in Djblets 5.3 / Review Board 7.0.1, we're including a backport of the modern `log_timed()`. This will be removed when we can depend on newer releases.	82bd30ed92bcdb85dd22f401f16c0e4844a3d018
	Add log timers around all communication over Celery. In order to help debug networking-related problems, we now include log timers around all outgoing requests to Celery. This includes task runs and tool refreshes. These are DEBUG-logged unless timing exceeds a threshold, helping to catch delayed requests. As this utilizes new functionality in Djblets 5.3 / Review Board 7.0.1, we're including a backport of the modern `log_timed()`. This will be removed when we can depend on newer releases.	954127f1816b68be0ea84eae612db4f8edbed2c5

Diff:

Revision 2 (+788 -90)

Show changes

	extension/reviewbotext/extension.py
	extension/reviewbotext/integration.py
	extension/reviewbotext/views.py
	extension/reviewbotext/compat/__init__.py
	extension/reviewbotext/compat/logs.py

Checks run (2 succeeded)

flake8 passed.

JSHint passed.

extension/reviewbotext/compat/__init__.py (Diff revision 2)
The issue has been resolved. Show all issues
```
Shouldn't this be 4.0.1? Same elsewhere in this change.
```

Change Summary:

Fixed the version to target 4.0.1.

Commits:

	Summary	ID
	Add log timers around all communication over Celery. In order to help debug networking-related problems, we now include log timers around all outgoing requests to Celery. This includes task runs and tool refreshes. These are DEBUG-logged unless timing exceeds a threshold, helping to catch delayed requests. As this utilizes new functionality in Djblets 5.3 / Review Board 7.0.1, we're including a backport of the modern `log_timed()`. This will be removed when we can depend on newer releases.	954127f1816b68be0ea84eae612db4f8edbed2c5
	Add log timers around all communication over Celery. In order to help debug networking-related problems, we now include log timers around all outgoing requests to Celery. This includes task runs and tool refreshes. These are DEBUG-logged unless timing exceeds a threshold, helping to catch delayed requests. As this utilizes new functionality in Djblets 5.3 / Review Board 7.0.1, we're including a backport of the modern `log_timed()`. This will be removed when we can depend on newer releases.	839f20a186152d9427d7e714af409a3fa7e921cf

Diff:

Revision 3 (+788 -90)

Show changes

	extension/reviewbotext/extension.py
	extension/reviewbotext/integration.py
	extension/reviewbotext/views.py
	extension/reviewbotext/compat/__init__.py
	extension/reviewbotext/compat/logs.py

Checks run (2 succeeded)

flake8 passed.

JSHint passed.

Fix it!

extension/reviewbotext/compat/logs.py (Diff revision 3)

An issue was opened. Show all issues

These look like they were copy/pasted from djblets. I don't think we need the version info here at all.