Add log timers around all outbound communication code.

Review Request #14371 — Created March 17, 2025 and updated

Information

Review Board
release-7.1.x

Reviewers

When networks act up, Review Board can hit issues with timeouts or
delayed processing of requests. It can sometimes be hard to diagnose
what's going on in these cases.

In an effort to address this, we now have log timers around all code
invoking HTTP requests, sending e-mails, communicating with
repositories, publishing, and performing security checks.

These are DEBUG logs in most cases, so administrators will only see new
log items if operations are taking too long (triggering the WARNING or
CRTICIAL levels).

All unit tests pass.

Tested sending e-mails, fetching branches and commits, viewing diffs,
and triggered a webhook.

Summary ID
Add log timers around all outbound communication code.
When networks act up, Review Board can hit issues with timeouts or delayed processing of requests. It can sometimes be hard to diagnose what's going on in these cases. In an effort to address this, we now have log timers around all code invoking HTTP requests, sending e-mails, communicating with repositories, publishing, and performing security checks. These are DEBUG logs in most cases, so administrators will only see new log items if operations are taking too long (triggering the WARNING or CRTICIAL levels).
21551ea6d7f691fd949b6d1aff4c72645a762a8a
Description From Last Updated

Testing done?

daviddavid
There are no open issues
chipx86
david
  1. 
      
  2. Show all issues

    Testing done?

  3. 
      
chipx86
Review request changed
Testing Done:
  +

All unit tests pass.

  +
  +

Tested sending e-mails, fetching branches and commits, viewing diffs,

  + and triggered a webhook.

david
  1. Ship It!
  2. 
      
Loading...