Add log timers around all outbound communication code.
Review Request #14371 — Created March 17, 2025 and updated
When networks act up, Review Board can hit issues with timeouts or
delayed processing of requests. It can sometimes be hard to diagnose
what's going on in these cases.In an effort to address this, we now have log timers around all code
invoking HTTP requests, sending e-mails, communicating with
repositories, publishing, and performing security checks.These are DEBUG logs in most cases, so administrators will only see new
log items if operations are taking too long (triggering the WARNING or
CRTICIAL levels).
All unit tests pass.
Tested sending e-mails, fetching branches and commits, viewing diffs,
and triggered a webhook.
Summary | ID |
---|---|
21551ea6d7f691fd949b6d1aff4c72645a762a8a |
Description | From | Last Updated | ||
---|---|---|---|---|
Testing done? |
|
|||
There are no open issues |
- Change Summary:
-
Removed the hosting service name from the
HostingServiceHTTPRequest
logging when there's no associated hosting service, since this is used by rbintegrations as a general HTTP request API. - Commits:
-
Summary ID 69ea4a2ccf099f43d21d6ef7f60a79cb359e0cd2 21551ea6d7f691fd949b6d1aff4c72645a762a8a - Diff:
-
Revision 2 (+1128 -892)