Summary

Fix unit test regressions with badges and conditionally access context.

Review Request #14368 — Created March 14, 2025 and discarded March 21, 2025, 12:57 a.m.

Information

Owner

chipx86

Repository

Review Board

Branch

release-7.1.x

Bugs

Depends On

Reviewers

Groups

reviewboard

People

Description

When get_user_badges() was updated to take a local_site= parameter,
two unit tests failed to get the update. They were caught up in a stash.
These have been updated to take **kwargs.

Badge calculation also assumed the existence of request.local_site and
context['request']`, but these aren't always available, at least in unit
tests. We now access these conditionally.

Testing Done

All unit tests pass.

Commits

Summary	ID
Fix unit test regressions with badges and conditionally access context. When `get_user_badges()` was updated to take a `local_site=` parameter, two unit tests failed to get the update. They were caught up in a stash. These have been updated to take `**kwargs`. Badge calculation also assumed the existence of `request.local_site` and context['request']`, but these aren't always available, at least in unit tests. We now access these conditionally.	40f37da00d2fef339731e08527aaf5b1104c41fc

Summary

Fix unit test regressions with badges and conditionally access context.

When `get_user_badges()` was updated to take a `local_site=` parameter, two unit tests failed to get the update. They were caught up in a stash. These have been updated to take `**kwargs`. Badge calculation also assumed the existence of `request.local_site` and context['request']`, but these aren't always available, at least in unit tests. We now access these conditionally.

40f37da00d2fef339731e08527aaf5b1104c41fc

flake8 passed.

JSHint passed.

Ship it!

```
Ship It!
```

Ship it!

```
Ship It!
```

Status:: Discarded