Summary

Add a setting for the default tabstop width.

Review Request #14361 — Created March 4, 2025 and submitted March 17, 2025, 8:55 a.m.

Information

Owner

david

Repository

Review Board

Branch

release-7.x

Bugs

839

Depends On

Reviewers

Groups

reviewboard

People

Description

One frequent request is to have the ability to show tabstops as
something other than 8 characters. When we first started getting this
request, the tab-size CSS rule was very poorly supported, and so there
wasn't much we could do. Many years later, it's been properly
implemented in all the browsers we care about, so it's well past time to
support this use case.

This change lays the framework for doing this, and implements the bare
minimum case of setting a global default for the tabstop size. This
involves several pieces:

A new extra dict has been added to the diff file context and plumbed
through the diff viewer, views, and JS model.
A new setting for the default has been added to siteconfig and the
DiffSettings object. The settings has been plumbed through a few
more places in order to get it where it needs to go for this.
Plumb the diff settings/tab size through into the chunk and opcode
generators, so that they will take it into account (for things like
indentation change markers).
The DiffReviewableView will check if there's a tab_size key in the
extra object, and use that to set the CSS for the file.

A natural future enhancement to this is to add an extension hook that
can modify the DiffSettings for an individual file, which will allow us
to build an extension that could do things like use .editorconfig files
in order to manage this on a per-path or per-file-type basis. It might
also be nice to give the user some kind of UI for changing the displayed
tabstop width for a file on the client side.

While in here, this fixes up a typo in the diff settings form, and the
diff settings form documentation.

Testing Done


Set the tabstop setting to various options (empty, 0, 4, 8, 12) and

  saw that it was properly reflected in the diff viewer for a change

  involving tabs.
Tested that indentation change markers worked correctly with different

  tabstop settings, including 1 and 2 characters (where the marker is

  truncated to fit in the space).
Ran unit tests.

Commits

Summary	ID
Add a setting for the default tabstop width. One frequent request is to have the ability to show tabstops as something other than 8 characters. When we first started getting this request, the `tab-size` CSS rule was very poorly supported, and so there wasn't much we could do. Many years later, it's been properly implemented in all the browsers we care about, so it's well past time to support this use case. This change lays the framework for doing this, and implements the bare minimum case of setting a global default for the tabstop size. This involves several pieces: - A new `extra` dict has been added to the diff file context and plumbed through the diff viewer, views, and JS model. - A new setting for the default has been added to siteconfig and the `DiffSettings` object. The settings has been plumbed through a few more places in order to get it where it needs to go for this. - Plumb the diff settings/tab size through into the chunk and opcode generators, so that they will take it into account (for things like indentation change markers). - The `DiffReviewableView` will check if there's a `tab_size` key in the `extra` object, and use that to set the CSS for the file. A natural future enhancement to this is to add an extension hook that can modify the DiffSettings for an individual file, which will allow us to build an extension that could do things like use `.editorconfig` files in order to manage this on a per-path or per-file-type basis. It might also be nice to give the user some kind of UI for changing the displayed tabstop width for a file on the client side. While in here, this fixes up a typo in the diff settings form, and the diff settings form documentation. Testing Done: - Set the tabstop setting to various options (empty, 0, 4, 8, 12) and saw that it was properly reflected in the diff viewer for a change involving tabs. - Tested that indentation change markers worked correctly with different tabstop settings, including 1 and 2 characters (where the marker is truncated to fit in the space). - Ran unit tests. Addresses bug 839.	a46adda8039b221464322c4c7749a42b45a43acf

Summary

Add a setting for the default tabstop width.

One frequent request is to have the ability to show tabstops as something other than 8 characters. When we first started getting this request, the `tab-size` CSS rule was very poorly supported, and so there wasn't much we could do. Many years later, it's been properly implemented in all the browsers we care about, so it's well past time to support this use case. This change lays the framework for doing this, and implements the bare minimum case of setting a global default for the tabstop size. This involves several pieces: - A new `extra` dict has been added to the diff file context and plumbed through the diff viewer, views, and JS model. - A new setting for the default has been added to siteconfig and the `DiffSettings` object. The settings has been plumbed through a few more places in order to get it where it needs to go for this. - Plumb the diff settings/tab size through into the chunk and opcode generators, so that they will take it into account (for things like indentation change markers). - The `DiffReviewableView` will check if there's a `tab_size` key in the `extra` object, and use that to set the CSS for the file. A natural future enhancement to this is to add an extension hook that can modify the DiffSettings for an individual file, which will allow us to build an extension that could do things like use `.editorconfig` files in order to manage this on a per-path or per-file-type basis. It might also be nice to give the user some kind of UI for changing the displayed tabstop width for a file on the client side. While in here, this fixes up a typo in the diff settings form, and the diff settings form documentation. Testing Done: - Set the tabstop setting to various options (empty, 0, 4, 8, 12) and saw that it was properly reflected in the diff viewer for a change involving tabs. - Tested that indentation change markers worked correctly with different tabstop settings, including 1 and 2 characters (where the marker is truncated to fit in the space). - Ran unit tests. Addresses bug 839.

a46adda8039b221464322c4c7749a42b45a43acf

Issues

Description	From	Last Updated
We should have documentation for this new setting in the /admin/configuration/diffviewer-settings/ docs page.	maubin	March 7, 2025, 2:34 p.m.
I think it'd be good to add a DiffSettingsTests unit test where you set the tab size to 0, and …	maubin	March 7, 2025, 2:37 p.m.
continuation line missing indentation or outdented Column: 5 Error code: E122	reviewbot	March 4, 2025, 12:31 p.m.
missing whitespace around parameter equals Column: 51 Error code: E252	reviewbot	March 4, 2025, 12:31 p.m.
missing whitespace around parameter equals Column: 52 Error code: E252	reviewbot	March 4, 2025, 12:31 p.m.
I feel like we should set this default in reviewboard.admin.siteconfig. Add a diffviewer_default_tab_size entry there and set it to DiffOpcodeGenerator.TAB_SIZE, …	maubin	March 7, 2025, 2:33 p.m.
If we do set the default tab size in siteconfig, then we probably don't need to do this here? And …	maubin	March 7, 2025, 2:33 p.m.
Can you add a Version Added here.	maubin	March 7, 2025, 2:34 p.m.
Can you add a Version Added here.	maubin	March 7, 2025, 2:34 p.m.
Should be two blank lines between content and reference definitions.	chipx86	March 12, 2025, 8:45 a.m.
I think we can just make implementations plural. Also, missing a trailing period.	chipx86	March 12, 2025, 8:45 a.m.
Should probably use Sequence instead of list.	chipx86	March 12, 2025, 8:46 a.m.
Sequence here as well.	chipx86	March 12, 2025, 8:46 a.m.
Can you update this to use the standard typed function indentation form?	chipx86	March 12, 2025, 8:47 a.m.
I think this is missing Version Added.	chipx86	March 12, 2025, 8:47 a.m.
These should be the same import group.	chipx86	March 12, 2025, 8:48 a.m.
Thinking DiffSettings should define a DEFAULT_TAB_SIZE, and then we can reference this here and assign the others to alias that. …	chipx86	March 12, 2025, 8:57 a.m.
This could be one statement now.	chipx86	March 12, 2025, 8:52 a.m.
Should this be Mapping? Unless we mutate it later.	chipx86	March 12, 2025, 8:54 a.m.
We're missing **kwargs in the docs here.	chipx86	March 12, 2025, 8:54 a.m.
Might as well cut out the middle man and change this to DiffSettings.DEFAULT_TAB_SIZE now.	maubin	March 14, 2025, 9:58 a.m.
Same here and below.	maubin	March 14, 2025, 9:58 a.m.

flake8 failed.

JSHint passed.

flake8

reviewboard/admin/forms/diff_settings.py (Diff revision 1)
The issue has been resolved. Show all issues
```
continuation line missing indentation or outdented

Column: 5
Error code: E122
```
reviewboard/diffviewer/chunk_generator.py (Diff revision 1)
The issue has been resolved. Show all issues
```
missing whitespace around parameter equals

Column: 51
Error code: E252
```
reviewboard/diffviewer/chunk_generator.py (Diff revision 1)
The issue has been resolved. Show all issues
```
missing whitespace around parameter equals

Column: 52
Error code: E252
```

Commits:

	Summary	ID
	Add a setting for the default tabstop width. One frequent request is to have the ability to show tabstops as something other than 8 characters. When we first started getting this request, the `tab-size` CSS rule was very poorly supported, and so there wasn't much we could do. Many years later, it's been properly implemented in all the browsers we care about, so it's well past time to support this use case. This change lays the framework for doing this, and implements the bare minimum case of setting a global default for the tabstop size. This involves several pieces: - A new `extra` dict has been added to the diff file context and plumbed through the diff viewer, views, and JS model. - A new setting for the default has been added to siteconfig and the `DiffSettings` object. The settings has been plumbed through a few more places in order to get it where it needs to go for this. - Plumb the diff settings/tab size through into the chunk and opcode generators, so that they will take it into account (for things like indentation change markers). - The `DiffReviewableView` will check if there's a `tab_size` key in the `extra` object, and use that to set the CSS for the file. A natural future enhancement to this is to add an extension hook that can modify the DiffSettings for an individual file, which will allow us to build an extension that could do things like use `.editorconfig` files in order to manage this on a per-path or per-file-type basis. It might also be nice to give the user some kind of UI for changing the displayed tabstop width for a file on the client side. Testing Done: - Set the tabstop setting to various options (empty, 0, 4, 8, 12) and saw that it was properly reflected in the diff viewer for a change involving tabs. - Tested that indentation change markers worked correctly with different tabstop settings, including 1 and 2 characters (where the marker is truncated to fit in the space). - Ran unit tests.	9c5e5513aaadb2b2aa94270d4c8a50cce1557419
	Add a setting for the default tabstop width. One frequent request is to have the ability to show tabstops as something other than 8 characters. When we first started getting this request, the `tab-size` CSS rule was very poorly supported, and so there wasn't much we could do. Many years later, it's been properly implemented in all the browsers we care about, so it's well past time to support this use case. This change lays the framework for doing this, and implements the bare minimum case of setting a global default for the tabstop size. This involves several pieces: - A new `extra` dict has been added to the diff file context and plumbed through the diff viewer, views, and JS model. - A new setting for the default has been added to siteconfig and the `DiffSettings` object. The settings has been plumbed through a few more places in order to get it where it needs to go for this. - Plumb the diff settings/tab size through into the chunk and opcode generators, so that they will take it into account (for things like indentation change markers). - The `DiffReviewableView` will check if there's a `tab_size` key in the `extra` object, and use that to set the CSS for the file. A natural future enhancement to this is to add an extension hook that can modify the DiffSettings for an individual file, which will allow us to build an extension that could do things like use `.editorconfig` files in order to manage this on a per-path or per-file-type basis. It might also be nice to give the user some kind of UI for changing the displayed tabstop width for a file on the client side. Testing Done: - Set the tabstop setting to various options (empty, 0, 4, 8, 12) and saw that it was properly reflected in the diff viewer for a change involving tabs. - Tested that indentation change markers worked correctly with different tabstop settings, including 1 and 2 characters (where the marker is truncated to fit in the space). - Ran unit tests. Addresses bug 839.	306873257031931119f3738b46d9c277408ef4ef

Diff:

Revision 2 (+942 -230)

Show changes

	reviewboard/admin/forms/diff_settings.py
	reviewboard/diffviewer/chunk_generator.py
	reviewboard/diffviewer/diffutils.py
	reviewboard/diffviewer/opcode_generator.py
	reviewboard/diffviewer/settings.py
	reviewboard/diffviewer/views.py
	reviewboard/diffviewer/tests/test_diff_settings.py
	reviewboard/diffviewer/tests/test_diffutils.py
	4 more

Checks run (2 succeeded)

flake8 passed.

JSHint passed.

The issue has been resolved. Show all issues

We should have documentation for this new setting in the /admin/configuration/diffviewer-settings/ docs page.

david March 7, 2025, 2:51 p.m.

Wow, that whole doc is pretty out of date. Will get it fixed up to match the modern form.

The issue has been resolved. Show all issues

I think it'd be good to add a DiffSettingsTests unit test where you set the tab size to 0, and assert that it gets changed to None.

reviewboard/diffviewer/chunk_generator.py (Diff revision 2)

The issue has been resolved. Show all issues

I feel like we should set this default in reviewboard.admin.siteconfig. Add a diffviewer_default_tab_size entry there and set it to DiffOpcodeGenerator.TAB_SIZE, so that we can expect there to be a default value in siteconfig if we're ever working with tab sizes outside of this class.

reviewboard/diffviewer/chunk_generator.py (Diff revision 2)

The issue has been resolved. Show all issues

If we do set the default tab size in siteconfig, then we probably don't need to do this here? And could maybe get rid of the TAB_SIZE attribute here altogether, so that we only have one default value to manage.

david March 7, 2025, 2:51 p.m.

We still want to handle blank/zero values. I'll move that into DiffSettings, though.

reviewboard/diffviewer/settings.py (Diff revision 2)
The issue has been resolved. Show all issues
```
Can you add a Version Added here.
```
reviewboard/reviews/views/diffviewer.py (Diff revision 2)
The issue has been resolved. Show all issues
```
Can you add a Version Added here.
```

Description:

		One frequent request is to have the ability to show tabstops as
		something other than 8 characters. When we first started getting this
		request, the `tab-size` CSS rule was very poorly supported, and so there
		wasn't much we could do. Many years later, it's been properly
		implemented in all the browsers we care about, so it's well past time to
		support this use case.

		This change lays the framework for doing this, and implements the bare
		minimum case of setting a global default for the tabstop size. This
		involves several pieces:

		A new `extra` dict has been added to the diff file context and plumbed through the diff viewer, views, and JS model.
		A new setting for the default has been added to siteconfig and the `DiffSettings` object. The settings has been plumbed through a few more places in order to get it where it needs to go for this.
		Plumb the diff settings/tab size through into the chunk and opcode generators, so that they will take it into account (for things like indentation change markers).
		The `DiffReviewableView` will check if there's a `tab_size` key in the `extra` object, and use that to set the CSS for the file.

		A natural future enhancement to this is to add an extension hook that
		can modify the DiffSettings for an individual file, which will allow us
		to build an extension that could do things like use `.editorconfig` files
		in order to manage this on a per-path or per-file-type basis. It might
		also be nice to give the user some kind of UI for changing the displayed
		tabstop width for a file on the client side.
	+
	+	While in here, this fixes up a typo in the diff settings form, and the
	+	diff settings form documentation.

Commits:

	Summary	ID
	Add a setting for the default tabstop width. One frequent request is to have the ability to show tabstops as something other than 8 characters. When we first started getting this request, the `tab-size` CSS rule was very poorly supported, and so there wasn't much we could do. Many years later, it's been properly implemented in all the browsers we care about, so it's well past time to support this use case. This change lays the framework for doing this, and implements the bare minimum case of setting a global default for the tabstop size. This involves several pieces: - A new `extra` dict has been added to the diff file context and plumbed through the diff viewer, views, and JS model. - A new setting for the default has been added to siteconfig and the `DiffSettings` object. The settings has been plumbed through a few more places in order to get it where it needs to go for this. - Plumb the diff settings/tab size through into the chunk and opcode generators, so that they will take it into account (for things like indentation change markers). - The `DiffReviewableView` will check if there's a `tab_size` key in the `extra` object, and use that to set the CSS for the file. A natural future enhancement to this is to add an extension hook that can modify the DiffSettings for an individual file, which will allow us to build an extension that could do things like use `.editorconfig` files in order to manage this on a per-path or per-file-type basis. It might also be nice to give the user some kind of UI for changing the displayed tabstop width for a file on the client side. Testing Done: - Set the tabstop setting to various options (empty, 0, 4, 8, 12) and saw that it was properly reflected in the diff viewer for a change involving tabs. - Tested that indentation change markers worked correctly with different tabstop settings, including 1 and 2 characters (where the marker is truncated to fit in the space). - Ran unit tests. Addresses bug 839.	306873257031931119f3738b46d9c277408ef4ef
	Add a setting for the default tabstop width. One frequent request is to have the ability to show tabstops as something other than 8 characters. When we first started getting this request, the `tab-size` CSS rule was very poorly supported, and so there wasn't much we could do. Many years later, it's been properly implemented in all the browsers we care about, so it's well past time to support this use case. This change lays the framework for doing this, and implements the bare minimum case of setting a global default for the tabstop size. This involves several pieces: - A new `extra` dict has been added to the diff file context and plumbed through the diff viewer, views, and JS model. - A new setting for the default has been added to siteconfig and the `DiffSettings` object. The settings has been plumbed through a few more places in order to get it where it needs to go for this. - Plumb the diff settings/tab size through into the chunk and opcode generators, so that they will take it into account (for things like indentation change markers). - The `DiffReviewableView` will check if there's a `tab_size` key in the `extra` object, and use that to set the CSS for the file. A natural future enhancement to this is to add an extension hook that can modify the DiffSettings for an individual file, which will allow us to build an extension that could do things like use `.editorconfig` files in order to manage this on a per-path or per-file-type basis. It might also be nice to give the user some kind of UI for changing the displayed tabstop width for a file on the client side. While in here, this fixes up a typo in the diff settings form, and the diff settings form documentation. Testing Done: - Set the tabstop setting to various options (empty, 0, 4, 8, 12) and saw that it was properly reflected in the diff viewer for a change involving tabs. - Tested that indentation change markers worked correctly with different tabstop settings, including 1 and 2 characters (where the marker is truncated to fit in the space). - Ran unit tests. Addresses bug 839.	535fcf86c02f100f5609458c6ad289f3a9f27c98

Diff:

Revision 3 (+1126 -286)

Show changes

	docs/manual/admin/configuration/diffviewer-settings.rst
	reviewboard/admin/siteconfig.py
	reviewboard/admin/forms/diff_settings.py
	reviewboard/diffviewer/chunk_generator.py
	reviewboard/diffviewer/diffutils.py
	reviewboard/diffviewer/opcode_generator.py
	reviewboard/diffviewer/settings.py
	reviewboard/diffviewer/views.py
	6 more

Checks run (2 succeeded)

flake8 passed.

JSHint passed.

docs/manual/admin/configuration/diffviewer-settings.rst (Diff revision 3)
The issue has been resolved. Show all issues
```
Should be two blank lines between content and reference definitions.
```
reviewboard/diffviewer/chunk_generator.py (Diff revision 3)
The issue has been resolved. Show all issues
```
I think we can just make implementations plural.
Also, missing a trailing period.
```
reviewboard/diffviewer/chunk_generator.py (Diff revision 3)
The issue has been resolved. Show all issues
```
Should probably use Sequence instead of list.
```
reviewboard/diffviewer/chunk_generator.py (Diff revision 3)
The issue has been resolved. Show all issues
```
Sequence here as well.
```

reviewboard/diffviewer/chunk_generator.py (Diff revision 3)

The issue has been resolved. Show all issues

Can you update this to use the standard typed function indentation form?

reviewboard/diffviewer/diffutils.py (Diff revision 3)
The issue has been resolved. Show all issues
```
I think this is missing Version Added.
```
reviewboard/diffviewer/opcode_generator.py (Diff revision 3)
The issue has been resolved. Show all issues
```
These should be the same import group.
```

reviewboard/diffviewer/settings.py (Diff revision 3)

The issue has been resolved. Show all issues

Thinking DiffSettings should define a DEFAULT_TAB_SIZE, and then we can reference this here and assign the others to alias that. That way the default lives in one place and we don't have to lazily-import (I think?).

reviewboard/diffviewer/views.py (Diff revision 3)
The issue has been resolved. Show all issues
```
This could be one statement now.
```
reviewboard/diffviewer/views.py (Diff revision 3)
The issue has been resolved. Show all issues
```
Should this be Mapping? Unless we mutate it later.
```
reviewboard/diffviewer/views.py (Diff revision 3)
The issue has been resolved. Show all issues
```
We're missing **kwargs in the docs here.
```

Commits:

	Summary	ID
	Add a setting for the default tabstop width. One frequent request is to have the ability to show tabstops as something other than 8 characters. When we first started getting this request, the `tab-size` CSS rule was very poorly supported, and so there wasn't much we could do. Many years later, it's been properly implemented in all the browsers we care about, so it's well past time to support this use case. This change lays the framework for doing this, and implements the bare minimum case of setting a global default for the tabstop size. This involves several pieces: - A new `extra` dict has been added to the diff file context and plumbed through the diff viewer, views, and JS model. - A new setting for the default has been added to siteconfig and the `DiffSettings` object. The settings has been plumbed through a few more places in order to get it where it needs to go for this. - Plumb the diff settings/tab size through into the chunk and opcode generators, so that they will take it into account (for things like indentation change markers). - The `DiffReviewableView` will check if there's a `tab_size` key in the `extra` object, and use that to set the CSS for the file. A natural future enhancement to this is to add an extension hook that can modify the DiffSettings for an individual file, which will allow us to build an extension that could do things like use `.editorconfig` files in order to manage this on a per-path or per-file-type basis. It might also be nice to give the user some kind of UI for changing the displayed tabstop width for a file on the client side. While in here, this fixes up a typo in the diff settings form, and the diff settings form documentation. Testing Done: - Set the tabstop setting to various options (empty, 0, 4, 8, 12) and saw that it was properly reflected in the diff viewer for a change involving tabs. - Tested that indentation change markers worked correctly with different tabstop settings, including 1 and 2 characters (where the marker is truncated to fit in the space). - Ran unit tests. Addresses bug 839.	535fcf86c02f100f5609458c6ad289f3a9f27c98
	Add a setting for the default tabstop width. One frequent request is to have the ability to show tabstops as something other than 8 characters. When we first started getting this request, the `tab-size` CSS rule was very poorly supported, and so there wasn't much we could do. Many years later, it's been properly implemented in all the browsers we care about, so it's well past time to support this use case. This change lays the framework for doing this, and implements the bare minimum case of setting a global default for the tabstop size. This involves several pieces: - A new `extra` dict has been added to the diff file context and plumbed through the diff viewer, views, and JS model. - A new setting for the default has been added to siteconfig and the `DiffSettings` object. The settings has been plumbed through a few more places in order to get it where it needs to go for this. - Plumb the diff settings/tab size through into the chunk and opcode generators, so that they will take it into account (for things like indentation change markers). - The `DiffReviewableView` will check if there's a `tab_size` key in the `extra` object, and use that to set the CSS for the file. A natural future enhancement to this is to add an extension hook that can modify the DiffSettings for an individual file, which will allow us to build an extension that could do things like use `.editorconfig` files in order to manage this on a per-path or per-file-type basis. It might also be nice to give the user some kind of UI for changing the displayed tabstop width for a file on the client side. While in here, this fixes up a typo in the diff settings form, and the diff settings form documentation. Testing Done: - Set the tabstop setting to various options (empty, 0, 4, 8, 12) and saw that it was properly reflected in the diff viewer for a change involving tabs. - Tested that indentation change markers worked correctly with different tabstop settings, including 1 and 2 characters (where the marker is truncated to fit in the space). - Ran unit tests. Addresses bug 839.	6ba793eebd4a46bf39d300ac61de7cc723e31888

Diff:

Revision 4 (+1178 -304)

Show changes

	docs/manual/admin/configuration/diffviewer-settings.rst
	reviewboard/admin/siteconfig.py
	reviewboard/admin/forms/diff_settings.py
	reviewboard/diffviewer/chunk_generator.py
	reviewboard/diffviewer/diffutils.py
	reviewboard/diffviewer/opcode_generator.py
	reviewboard/diffviewer/settings.py
	reviewboard/diffviewer/views.py
	6 more

Checks run (2 succeeded)

flake8 passed.

JSHint passed.

reviewboard/admin/siteconfig.py (Diff revision 4)

The issue has been resolved. Show all issues

Might as well cut out the middle man and change this to DiffSettings.DEFAULT_TAB_SIZE now.

reviewboard/diffviewer/tests/test_diff_settings.py (Diff revision 4)
The issue has been resolved. Show all issues
```
Same here and below.
```

Commits:

	Summary	ID
	Add a setting for the default tabstop width. One frequent request is to have the ability to show tabstops as something other than 8 characters. When we first started getting this request, the `tab-size` CSS rule was very poorly supported, and so there wasn't much we could do. Many years later, it's been properly implemented in all the browsers we care about, so it's well past time to support this use case. This change lays the framework for doing this, and implements the bare minimum case of setting a global default for the tabstop size. This involves several pieces: - A new `extra` dict has been added to the diff file context and plumbed through the diff viewer, views, and JS model. - A new setting for the default has been added to siteconfig and the `DiffSettings` object. The settings has been plumbed through a few more places in order to get it where it needs to go for this. - Plumb the diff settings/tab size through into the chunk and opcode generators, so that they will take it into account (for things like indentation change markers). - The `DiffReviewableView` will check if there's a `tab_size` key in the `extra` object, and use that to set the CSS for the file. A natural future enhancement to this is to add an extension hook that can modify the DiffSettings for an individual file, which will allow us to build an extension that could do things like use `.editorconfig` files in order to manage this on a per-path or per-file-type basis. It might also be nice to give the user some kind of UI for changing the displayed tabstop width for a file on the client side. While in here, this fixes up a typo in the diff settings form, and the diff settings form documentation. Testing Done: - Set the tabstop setting to various options (empty, 0, 4, 8, 12) and saw that it was properly reflected in the diff viewer for a change involving tabs. - Tested that indentation change markers worked correctly with different tabstop settings, including 1 and 2 characters (where the marker is truncated to fit in the space). - Ran unit tests. Addresses bug 839.	6ba793eebd4a46bf39d300ac61de7cc723e31888
	Add a setting for the default tabstop width. One frequent request is to have the ability to show tabstops as something other than 8 characters. When we first started getting this request, the `tab-size` CSS rule was very poorly supported, and so there wasn't much we could do. Many years later, it's been properly implemented in all the browsers we care about, so it's well past time to support this use case. This change lays the framework for doing this, and implements the bare minimum case of setting a global default for the tabstop size. This involves several pieces: - A new `extra` dict has been added to the diff file context and plumbed through the diff viewer, views, and JS model. - A new setting for the default has been added to siteconfig and the `DiffSettings` object. The settings has been plumbed through a few more places in order to get it where it needs to go for this. - Plumb the diff settings/tab size through into the chunk and opcode generators, so that they will take it into account (for things like indentation change markers). - The `DiffReviewableView` will check if there's a `tab_size` key in the `extra` object, and use that to set the CSS for the file. A natural future enhancement to this is to add an extension hook that can modify the DiffSettings for an individual file, which will allow us to build an extension that could do things like use `.editorconfig` files in order to manage this on a per-path or per-file-type basis. It might also be nice to give the user some kind of UI for changing the displayed tabstop width for a file on the client side. While in here, this fixes up a typo in the diff settings form, and the diff settings form documentation. Testing Done: - Set the tabstop setting to various options (empty, 0, 4, 8, 12) and saw that it was properly reflected in the diff viewer for a change involving tabs. - Tested that indentation change markers worked correctly with different tabstop settings, including 1 and 2 characters (where the marker is truncated to fit in the space). - Ran unit tests. Addresses bug 839.	a46adda8039b221464322c4c7749a42b45a43acf

Diff:

Revision 5 (+1176 -304)

Show changes

	docs/manual/admin/configuration/diffviewer-settings.rst
	reviewboard/admin/siteconfig.py
	reviewboard/admin/forms/diff_settings.py
	reviewboard/diffviewer/chunk_generator.py
	reviewboard/diffviewer/diffutils.py
	reviewboard/diffviewer/opcode_generator.py
	reviewboard/diffviewer/settings.py
	reviewboard/diffviewer/views.py
	6 more

Checks run (2 succeeded)

flake8 passed.

JSHint passed.

Ship it!

```
Ship It!
```

Ship it!

```
Ship It!
```

Status:: Completed
Change Summary:: Pushed to release-7.x (16d0713)