This change has been marked as completed.

Describe the completed change (optional):

Pushed to release-5.x (b886f19)

Summary

Fix a typing import for < Python3.11.

Review Request #14351 — Created Feb. 18, 2025 and submitted 1 month, 1 week ago

Information

Owner

maubin*

Repository

Djblets

Branch

release-5.x

Bugs

Depends On

Reviewers

Groups

djblets

People

Description*

There's one area where we import Self from typing. This is only

available in Python3.11+, and since we still support Python 3.8-3.10 we

need to import from typing_extensions instead to avoid issues. This

change does that.

Testing Done

Ran unit tests. Used Djblets with Python 3.9.

Commits

Summary	ID
Fix a typing import for < Python3.11. There's one area where we import `Self` from `typing`. This is only available in Python3.11+, and since we still support Python 3.8-3.10 we need to import from `typing_extensions` instead to avoid issues. This change does that.	89ec1f090a29f984ca7fcc1f5b51900a630d2d11

Description	From	Last Updated
There are no open issues

flake8 passed.

JSHint passed.

Ship it!

```
Ship It!
```

Ship it!

```
Ship It!
```

Status:: Completed
Change Summary:: Pushed to release-5.x (b886f19)