Override validation for CommaSeparatedValuesField.

 






 

 


  Review Request #14350
  —
  Created Feb. 17, 2025 and submitted  — Latest diff uploaded 

 


















 

  

   Information

  





 
 

  david
 









 
 

  Djblets
 









 
 

  release-5.x
 









 
 

  
 









 
 

  
 






 




 

  

   Reviewers

  





 
 

  djblets
 









 
 

  
 






 








 





  


 
 

  
The new comma separated values field that replaced the old

django-multiselectfield dependency was falling back on the base field

validation, which wasn't handling choices correctly. This change adds an

override so we actually iterate through the value instead of just

checking it directly.

 








  


 
 

  
Verified that saving changes to a comma-separated values field using a

multi checkbox widget worked correctly.

 







 









 





  








 




 







   

    
    
Changes between revision 1 and 2



    

 

 

 

 
orig
1
2
3
4

 



    


    

      
Commits

      

 

 

  
   
  
  Summary
  ID
  Author
 



 
  
 
 
  
   
    

     Override validation for CommaSeparatedValuesField.
     
The new comma separated values field that replaced the old
django-multiselectfield dependency was falling back on the base field
validation, which wasn't handling choices correctly. This change adds an
override so we actually iterate through the value instead of just
checking it directly.

Testing Done:
Verified that saving changes to a comma-separated values field using a
multi checkbox widget worked correctly.

    

   
  		
  5f39ca8382da6d7a4e3507622f30aa6c84e6bd01
  David Trowbridge
 


 
  
 
 
  
   
    

     Override validation for CommaSeparatedValuesField.
     
The new comma separated values field that replaced the old
django-multiselectfield dependency was falling back on the base field
validation, which wasn't handling choices correctly. This change adds an
override so we actually iterate through the value instead of just
checking it directly.

Testing Done:
Verified that saving changes to a comma-separated values field using a
multi checkbox widget worked correctly.

    

   
  		
  0d09dfde6d2d1eadd76ae7a6d6c1564ea02404c5
  David Trowbridge
 




    


    
    

   

  

 









 

  

   
    

     
      
      djblets/db/fields/comma_separated_values_field.py
     
    

   
  

 



 

  

   
    

     
      
      djblets/db/tests/test_comma_separated_values_field.py
     
    

   
  

 










     

    

   

  

  

   
   Loading...