Summary

Unconditionally try to load the SCM client when TREES is defined.

Review Request #14345 — Created Feb. 13, 2025 and submitted March 14, 2025, 5:11 p.m.

Information

Owner

david

Repository

RBTools

Branch

release-5.x

Bugs

Depends On

Reviewers

Groups

rbtools

People

Description

When someone is using the TREES setting for RBTools, it's common that
they'll be using repository paths as the keys to that. In this case, a
command like rbt patch --print would fail because it was trying to
avoid initializing the scmtool, and then we never got the correct server
URL.

This makes it so if TREES is present in the configuration (and now
also actually populated with data, since the default value will be {}),
and we otherwise did not need the scmtool, we'll still attempt to
initialize it. If we get it, then great, we can use it for TREES. If we
don't, we ignore that and proceed as previous.

Testing Done


Ran unit tests.
Verified that when TREES was defined, we now were initializing the

  scmtool when running rbt patch --print.

Commits

Summary	ID
Unconditionally try to load the SCM client when TREES is defined. When someone is using the `TREES` setting for RBTools, it's common that they'll be using repository paths as the keys to that. In this case, a command like `rbt patch --print` would fail because it was trying to avoid initializing the scmtool, and then we never got the correct server URL. This makes it so if `TREES` is present in the configuration (and now also actually populated with data, since the default value will be {}), and we otherwise did not need the scmtool, we'll still attempt to initialize it. If we get it, then great, we can use it for TREES. If we don't, we ignore that and proceed as previous. Testing Done: - Ran unit tests. - Verified that when TREES was defined, we now were initializing the scmtool when running `rbt patch --print`.	f26d447ed606ef248544b5b016afcc51c97ba7c6

Summary

Unconditionally try to load the SCM client when TREES is defined.

When someone is using the `TREES` setting for RBTools, it's common that they'll be using repository paths as the keys to that. In this case, a command like `rbt patch --print` would fail because it was trying to avoid initializing the scmtool, and then we never got the correct server URL. This makes it so if `TREES` is present in the configuration (and now also actually populated with data, since the default value will be {}), and we otherwise did not need the scmtool, we'll still attempt to initialize it. If we get it, then great, we can use it for TREES. If we don't, we ignore that and proceed as previous. Testing Done: - Ran unit tests. - Verified that when TREES was defined, we now were initializing the scmtool when running `rbt patch --print`.

f26d447ed606ef248544b5b016afcc51c97ba7c6

Issues

Description	From	Last Updated
Could shorten the if condition to just if trees := self.config.get('TREES')	maubin	Feb. 14, 2025, 10:26 a.m.
Could probably just be: if trees := self.config.get('TREES'):	chipx86	Feb. 19, 2025, 9:34 a.m.
Let's make this keyword-only.	chipx86	Feb. 19, 2025, 9:34 a.m.
Missing Version Added.	chipx86	Feb. 19, 2025, 9:34 a.m.

flake8 passed.

JSHint passed.

rbtools/commands/base/commands.py (Diff revision 1)
The issue has been resolved. Show all issues
```
Could shorten the if condition to just if trees := self.config.get('TREES')
```

rbtools/commands/base/commands.py (Diff revision 1)

The issue has been resolved. Show all issues

Could probably just be:

if trees := self.config.get('TREES'):

rbtools/commands/base/commands.py (Diff revision 1)
The issue has been resolved. Show all issues
```
Let's make this keyword-only.
```
rbtools/commands/base/commands.py (Diff revision 1)
The issue has been resolved. Show all issues
```
Missing Version Added.
```

Commits:

	Summary	ID
	Unconditionally try to load the SCM client when TREES is defined. When someone is using the `TREES` setting for RBTools, it's common that they'll be using repository paths as the keys to that. In this case, a command like `rbt patch --print` would fail because it was trying to avoid initializing the scmtool, and then we never got the correct server URL. This makes it so if `TREES` is present in the configuration (and now also actually populated with data, since the default value will be {}), and we otherwise did not need the scmtool, we'll still attempt to initialize it. If we get it, then great, we can use it for TREES. If we don't, we ignore that and proceed as previous. Testing Done: - Ran unit tests. - Verified that when TREES was defined, we now were initializing the scmtool when running `rbt patch --print`.	63ef0ef07378cbb21f99aecc1eaf44fbb7655a77
	Unconditionally try to load the SCM client when TREES is defined. When someone is using the `TREES` setting for RBTools, it's common that they'll be using repository paths as the keys to that. In this case, a command like `rbt patch --print` would fail because it was trying to avoid initializing the scmtool, and then we never got the correct server URL. This makes it so if `TREES` is present in the configuration (and now also actually populated with data, since the default value will be {}), and we otherwise did not need the scmtool, we'll still attempt to initialize it. If we get it, then great, we can use it for TREES. If we don't, we ignore that and proceed as previous. Testing Done: - Ran unit tests. - Verified that when TREES was defined, we now were initializing the scmtool when running `rbt patch --print`.	f26d447ed606ef248544b5b016afcc51c97ba7c6

Diff:

Revision 2 (+54 -10)

Show changes

	rbtools/clients/__init__.py
	rbtools/commands/base/commands.py

Checks run (2 succeeded)

flake8 passed.

JSHint passed.

Ship it!

```
Ship It!
```

Ship it!

```
Ship It!
```

Status:: Completed
Change Summary:: Pushed to release-5.x (df18c0c)