Summary

Add new resources, part 1/7.

Review Request #14340 — Created Feb. 10, 2025 and submitted April 30, 2025, 9:06 a.m.

Information

Owner

david

Repository

RBTools

Branch

master

Bugs

Depends On

Reviewers

Groups

rbtools

People

Description

This change adds the following new resource implementations:
- DefaultReviewerItemResource
- DefaultReviewerListResource
- ExtensionItemResource
- ExtensionListResource
- ReviewGroupItemResource
- ReviewGroupListResource
- ReviewGroupUserItemResource
- ReviewGroupUserListResource
- UserItemResource
- UserListResource
- UserFileAttachmentItemResource
- UserFileAttachmentListResource (split out from old
FileAttachmentListResource implementation)
- ValidationResource

Testing Done


Ran unit tests.
Used the new resources from a test script and saw that everything

  worked as expected.

Commits

Summary	ID
Add new resources, part 1/7. This change adds the following new resource implementations: - DefaultReviewerItemResource - DefaultReviewerListResource - ExtensionItemResource - ExtensionListResource - ReviewGroupItemResource - ReviewGroupListResource - ReviewGroupUserItemResource - ReviewGroupUserListResource - UserItemResource - UserListResource - UserFileAttachmentItemResource - UserFileAttachmentListResource (split out from old FileAttachmentListResource implementation) - ValidationResource Testing Done: - Ran unit tests. - Used the new resources from a test script and saw that everything worked as expected.	4954d6d0cd1aec657a4d323f4e07bac9eb22a52b

Summary

Add new resources, part 1/7.

This change adds the following new resource implementations: - DefaultReviewerItemResource - DefaultReviewerListResource - ExtensionItemResource - ExtensionListResource - ReviewGroupItemResource - ReviewGroupListResource - ReviewGroupUserItemResource - ReviewGroupUserListResource - UserItemResource - UserListResource - UserFileAttachmentItemResource - UserFileAttachmentListResource (split out from old FileAttachmentListResource implementation) - ValidationResource Testing Done: - Ran unit tests. - Used the new resources from a test script and saw that everything worked as expected.

4954d6d0cd1aec657a4d323f4e07bac9eb22a52b

Issues

Description	From	Last Updated
line too long (80 > 79 characters) Column: 80 Error code: E501	reviewbot	Feb. 10, 2025, 8:59 a.m.
Can we pull _excluded_links out, since we're doing the attribute lookup once per loop?	chipx86	March 20, 2025, 8:39 a.m.
Class variables should go above instance variables.	chipx86	March 20, 2025, 8:40 a.m.
Blank line between these.	chipx86	March 20, 2025, 8:40 a.m.

flake8 failed.

JSHint passed.

flake8

rbtools/api/resource/review_request.py (Diff revision 1)
The issue has been dropped. Show all issues
```
line too long (80 > 79 characters)

Column: 80
Error code: E501
```

Commits:

	Summary	ID
	Add new resources, part 1/7. This change adds the following new resource implementations: - DefaultReviewerItemResource - DefaultReviewerListResource - ExtensionItemResource - ExtensionListResource - ReviewGroupItemResource - ReviewGroupListResource - ReviewGroupUserItemResource - ReviewGroupUserListResource - UserItemResource - UserListResource - UserFileAttachmentItemResource - UserFileAttachmentListResource (split out from old FileAttachmentListResource implementation) - ValidationResource Testing Done: - Ran unit tests. - Used the new resources from a test script and saw that everything worked as expected.	b4ede8b45f2d9b5e1f8cbba3d187dde12eff16ef
	Add new resources, part 1/7. This change adds the following new resource implementations: - DefaultReviewerItemResource - DefaultReviewerListResource - ExtensionItemResource - ExtensionListResource - ReviewGroupItemResource - ReviewGroupListResource - ReviewGroupUserItemResource - ReviewGroupUserListResource - UserItemResource - UserListResource - UserFileAttachmentItemResource - UserFileAttachmentListResource (split out from old FileAttachmentListResource implementation) - ValidationResource Testing Done: - Ran unit tests. - Used the new resources from a test script and saw that everything worked as expected.	a931d098bd0026631572533b80c8566887e67ac4

Diff:

Revision 2 (+2262 -18)

Show changes

	rbtools/api/resource/__init__.py
	rbtools/api/resource/base.py
	rbtools/api/resource/base_user.py
	rbtools/api/resource/default_reviewer.py
	rbtools/api/resource/extension.py
	rbtools/api/resource/file_attachment.py
	rbtools/api/resource/review_group.py
	rbtools/api/resource/review_group_user.py
	5 more

Checks run (2 succeeded)

flake8 passed.

JSHint passed.

Ship it!

```
Ship It!
```

Commits:

	Summary	ID
	Add new resources, part 1/7. This change adds the following new resource implementations: - DefaultReviewerItemResource - DefaultReviewerListResource - ExtensionItemResource - ExtensionListResource - ReviewGroupItemResource - ReviewGroupListResource - ReviewGroupUserItemResource - ReviewGroupUserListResource - UserItemResource - UserListResource - UserFileAttachmentItemResource - UserFileAttachmentListResource (split out from old FileAttachmentListResource implementation) - ValidationResource Testing Done: - Ran unit tests. - Used the new resources from a test script and saw that everything worked as expected.	a931d098bd0026631572533b80c8566887e67ac4
	Add new resources, part 1/7. This change adds the following new resource implementations: - DefaultReviewerItemResource - DefaultReviewerListResource - ExtensionItemResource - ExtensionListResource - ReviewGroupItemResource - ReviewGroupListResource - ReviewGroupUserItemResource - ReviewGroupUserListResource - UserItemResource - UserListResource - UserFileAttachmentItemResource - UserFileAttachmentListResource (split out from old FileAttachmentListResource implementation) - ValidationResource Testing Done: - Ran unit tests. - Used the new resources from a test script and saw that everything worked as expected.	5e3135d3044391a87acd29cafe29818a9be29ec9

Diff:

Revision 3 (+2278 -18)

Show changes

	rbtools/api/resource/__init__.py
	rbtools/api/resource/base.py
	rbtools/api/resource/base_user.py
	rbtools/api/resource/default_reviewer.py
	rbtools/api/resource/extension.py
	rbtools/api/resource/file_attachment.py
	rbtools/api/resource/review_group.py
	rbtools/api/resource/review_group_user.py
	5 more

Checks run (2 succeeded)

flake8 passed.

JSHint passed.

rbtools/api/resource/base.py (Diff revision 3)

The issue has been resolved. Show all issues

Can we pull _excluded_links out, since we're doing the attribute lookup once per loop?

rbtools/api/resource/extension.py (Diff revision 3)
The issue has been resolved. Show all issues
```
Class variables should go above instance variables.
```
rbtools/api/resource/validation.py (Diff revision 3)
The issue has been resolved. Show all issues
```
Blank line between these.
```

Commits:

	Summary	ID
	Add new resources, part 1/7. This change adds the following new resource implementations: - DefaultReviewerItemResource - DefaultReviewerListResource - ExtensionItemResource - ExtensionListResource - ReviewGroupItemResource - ReviewGroupListResource - ReviewGroupUserItemResource - ReviewGroupUserListResource - UserItemResource - UserListResource - UserFileAttachmentItemResource - UserFileAttachmentListResource (split out from old FileAttachmentListResource implementation) - ValidationResource Testing Done: - Ran unit tests. - Used the new resources from a test script and saw that everything worked as expected.	5e3135d3044391a87acd29cafe29818a9be29ec9
	Add new resources, part 1/7. This change adds the following new resource implementations: - DefaultReviewerItemResource - DefaultReviewerListResource - ExtensionItemResource - ExtensionListResource - ReviewGroupItemResource - ReviewGroupListResource - ReviewGroupUserItemResource - ReviewGroupUserListResource - UserItemResource - UserListResource - UserFileAttachmentItemResource - UserFileAttachmentListResource (split out from old FileAttachmentListResource implementation) - ValidationResource Testing Done: - Ran unit tests. - Used the new resources from a test script and saw that everything worked as expected.	4954d6d0cd1aec657a4d323f4e07bac9eb22a52b

Diff:

Revision 4 (+2284 -18)

Show changes

	rbtools/api/resource/__init__.py
	rbtools/api/resource/base.py
	rbtools/api/resource/base_user.py
	rbtools/api/resource/default_reviewer.py
	rbtools/api/resource/extension.py
	rbtools/api/resource/file_attachment.py
	rbtools/api/resource/review_group.py
	rbtools/api/resource/review_group_user.py
	5 more

Checks run (2 succeeded)

flake8 passed.

JSHint passed.

Ship it!

```
Ship It!
```

Ship it!

```
Ship It!
```

Status:: Completed
Change Summary:: Pushed to master (e028669)