Summary

Modernize reviewbot.processing.

Review Request #14317 — Created Jan. 30, 2025 and submitted Feb. 11, 2025, 10:40 a.m.

Information

Owner

david

Repository

ReviewBot

Branch

master

Bugs

Depends On

Reviewers

Groups

reviewbot

People

Description

This change adds types and fixes up various style issues in the
reviewbot.processing module.

Testing Done

Ran unit tests.

Commits

Summary	ID
Modernize reviewbot.processing. This change adds types and fixes up various style issues in the reviewbot.processing module. Testing Done: Ran unit tests.	pppryrptttrqlsrlwyqozkqsuzwtlmls

Issues

Description	From	Last Updated
too many blank lines (3) Column: 1 Error code: E303	reviewbot	Jan. 30, 2025, 8:23 a.m.
I feel like we should maybe use a BaseCommentData as the parent class, since diff comments are not a type …	chipx86	Feb. 7, 2025, 8:24 a.m.
Can you use :file: here? Or, maybe better, :py:mod: with a module path, since the latter's linkable in docs?	chipx86	Feb. 7, 2025, 8:25 a.m.
Trailing ) should be aligned with the variable, like a dict or list.	chipx86	Feb. 7, 2025, 8:25 a.m.

flake8 failed.

JSHint passed.

flake8

bot/reviewbot/processing/review.py (Diff revision 1)
The issue has been dropped. Show all issues
```
too many blank lines (3)

Column: 1
Error code: E303
```

Commits:

	Summary	ID
	Modernize reviewbot.processing. This change adds types and fixes up various style issues in the reviewbot.processing module. Testing Done: Ran unit tests.	pppryrptttrqlsrlwyqozkqsuzwtlmls
	Modernize reviewbot.processing. This change adds types and fixes up various style issues in the reviewbot.processing module. Testing Done: Ran unit tests.	pppryrptttrqlsrlwyqozkqsuzwtlmls

Diff:

Revision 2 (+800 -318)

Show changes

	bot/reviewbot/processing/review.py
	bot/reviewbot/processing/tests/test_file.py
	bot/reviewbot/processing/tests/test_review.py

Checks run (2 succeeded)

flake8 passed.

JSHint passed.

Nice, this is a satisfying cleanup. Just a few nits.

bot/reviewbot/processing/review.py (Diff revision 2)

The issue has been resolved. Show all issues

I feel like we should maybe use a BaseCommentData as the parent class, since diff comments are not a type of general comment.

bot/reviewbot/processing/review.py (Diff revision 2)

The issue has been resolved. Show all issues

Can you use :file: here? Or, maybe better, :py:mod: with a module path, since the latter's linkable in docs?

bot/reviewbot/processing/review.py (Diff revision 2)
The issue has been resolved. Show all issues
```
Trailing ) should be aligned with the variable, like a dict or list.
```

Commits:

	Summary	ID
	Modernize reviewbot.processing. This change adds types and fixes up various style issues in the reviewbot.processing module. Testing Done: Ran unit tests.	pppryrptttrqlsrlwyqozkqsuzwtlmls
	Modernize reviewbot.processing. This change adds types and fixes up various style issues in the reviewbot.processing module. Testing Done: Ran unit tests.	pppryrptttrqlsrlwyqozkqsuzwtlmls

Diff:

Revision 3 (+820 -320)

Show changes

	bot/reviewbot/processing/review.py
	bot/reviewbot/processing/tests/test_file.py
	bot/reviewbot/processing/tests/test_review.py

Checks run (2 succeeded)

flake8 passed.

JSHint passed.

Ship it!

```
Ship It!
```

Ship it!

```
Ship It!
```

Status:: Completed
Change Summary:: Pushed to master (f97db4d)