Summary

Avoid too many User queries when calculating ReviewRequestPageData state.

Review Request #14316 — Created Jan. 30, 2025 and submitted March 19, 2025, 7:25 p.m.

Information

Owner

chipx86

Repository

Review Board

Branch

release-7.1.x

Bugs

Depends On

~~14313~~

Blocks

14315

Reviewers

Groups

reviewboard

People

Description

We query a lot of objects in ReviewRequestPageData, and many of these
have User objects associated. These end up being queried as separate
instances, which means that we lose out on any caching of profiles. This
ultimately leads to a lot of extra SQL queries per page.

We now determine all the users we know we have up-front, and then query
for for anything we're missing. Once we know we have all the users, we
re-attach the instances to the fetched objects, allowing the same
instances and cached state to be reused.

Testing Done

Unit tests pass.

Verified that the SQL queries on some test review requests have been
reduced.

Commits

Summary	ID
Avoid too many User queries when calculating ReviewRequestPageData state. We query a lot of objects in `ReviewRequestPageData`, and many of these have `User` objects associated. These end up being queried as separate instances, which means that we lose out on any caching of profiles. This ultimately leads to a lot of extra SQL queries per page. We now determine all the users we know we have up-front, and then query for for anything we're missing. Once we know we have all the users, we re-attach the instances to the fetched objects, allowing the same instances and cached state to be reused.	6a5049fa4e2b6c3cfc3977254a9da178253945bf

Summary

Avoid too many User queries when calculating ReviewRequestPageData state.

We query a lot of objects in `ReviewRequestPageData`, and many of these have `User` objects associated. These end up being queried as separate instances, which means that we lose out on any caching of profiles. This ultimately leads to a lot of extra SQL queries per page. We now determine all the users we know we have up-front, and then query for for anything we're missing. Once we know we have all the users, we re-attach the instances to the fetched objects, allowing the same instances and cached state to be reused.

6a5049fa4e2b6c3cfc3977254a9da178253945bf

flake8 passed.

JSHint passed.

Change Summary:

Updated for the recent changes to the unit tests.

Commits:

	Summary	ID
	Avoid too many User queries when calculating ReviewRequestPageData state. We query a lot of objects in `ReviewRequestPageData`, and many of these have `User` objects associated. These end up being queried as separate instances, which means that we lose out on any caching of profiles. This ultimately leads to a lot of extra SQL queries per page. We now determine all the users we know we have up-front, and then query for for anything we're missing. Once we know we have all the users, we re-attach the instances to the fetched objects, allowing the same instances and cached state to be reused.	371926ad05b6284d04767b181353991db15fdc95
	Avoid too many User queries when calculating ReviewRequestPageData state. We query a lot of objects in `ReviewRequestPageData`, and many of these have `User` objects associated. These end up being queried as separate instances, which means that we lose out on any caching of profiles. This ultimately leads to a lot of extra SQL queries per page. We now determine all the users we know we have up-front, and then query for for anything we're missing. Once we know we have all the users, we re-attach the instances to the fetched objects, allowing the same instances and cached state to be reused.	6a5049fa4e2b6c3cfc3977254a9da178253945bf

Diff:

Revision 2 (+92 -120)

Show changes

	reviewboard/reviews/detail.py
	reviewboard/reviews/tests/test_review_request_page_data.py

Checks run (2 succeeded)

flake8 passed.

JSHint passed.

Ship it!

```
Ship It!
```

Ship it!

```
Ship It!
```

Status:: Completed
Change Summary:: Pushed to release-7.1.x (34bc421)