Fix tests for modern clang and gotool error output.

Review Request #14304 — Created Jan. 23, 2025 and submitted — Latest diff uploaded

Information

ReviewBot
master

Reviewers

clang and gotool have both updated their error output, and our tests
were out of date. This change fixes that (and improves the gotool output
processing to only include errors and not any json activity entries that
get emitted during the run.

Ran unit tests.

Diff Revision 1 (Latest)

Commits

First Last Summary ID Author
Fix tests for modern clang and gotool error output.
clang and gotool have both updated their error output, and our tests were out of date. This change fixes that (and improves the gotool output processing to only include errors and not any json activity entries that get emitted during the run. Testing Done: Ran unit tests.
wvnnuqqvxpuspkzxzmuqvlozwxptulnx David Trowbridge
bot/reviewbot/tools/gotool.py
bot/reviewbot/tools/tests/test_clang.py
bot/reviewbot/tools/tests/test_gotool.py
Loading...