Summary

Update tests for DiffParser kwargs change.

Review Request #14287 — Created Jan. 7, 2025 and submitted Feb. 4, 2025, 8:12 a.m.

Information

Owner

david

Repository

Review Board

Branch

release-7.x

Bugs

Depends On

Reviewers

Groups

reviewboard

People

Description

A recent(ish) change made it so the args to DiffParser and friends are
keyword-only. This was causing a bunch of warnings to pop up when
running the tests.

Testing Done

Ran unit tests and saw no relevant warnings.

Commits

Summary	ID
Update tests for DiffParser kwargs change. A recent(ish) change made it so the args to DiffParser and friends are keyword-only. This was causing a bunch of warnings to pop up when running the tests. Testing Done: Ran unit tests and saw no relevant warnings.	6a4a57ac566cb1097415a3edd84ac352571d2cf6

Issues

Description	From	Last Updated
This is all pretty ugly. For all these tests, let's go with the style we typically use: parser = DiffXParser( …	chipx86	Jan. 16, 2025, 11:14 a.m.

flake8 passed.

JSHint passed.

reviewboard/diffviewer/tests/test_diffx_parser.py (Diff revision 1)

The issue has been resolved. Show all issues

This is all pretty ugly. For all these tests, let's go with the style we typically use:

parser = DiffXParser(
    data=(
        b'...'
        b'...'
    ),
    ...
)


or

parser = DiffXParser(data=(
    b'...'
    b'...'
)

Commits:

	Summary	ID
	Update tests for DiffParser kwargs change. A recent(ish) change made it so the args to DiffParser and friends are keyword-only. This was causing a bunch of warnings to pop up when running the tests. Testing Done: Ran unit tests and saw no relevant warnings.	3f76955f49a1fc4bdcdff2e78e3be000cfaf726e
	Update tests for DiffParser kwargs change. A recent(ish) change made it so the args to DiffParser and friends are keyword-only. This was causing a bunch of warnings to pop up when running the tests. Testing Done: Ran unit tests and saw no relevant warnings.	6a4a57ac566cb1097415a3edd84ac352571d2cf6

Diff:

Revision 2 (+134 -134)

Show changes

	reviewboard/diffviewer/tests/test_diff_parser.py
	reviewboard/diffviewer/tests/test_diffx_parser.py
	reviewboard/testing/scmtool.py

Checks run (2 succeeded)

flake8 passed.

JSHint passed.

Ship it!

```
Ship It!
```

Ship it!

```
Ship It!
```

Status:: Completed
Change Summary:: Pushed to release-7.x (6686a5e)