Add typing for ConditionsWidget.

 






 

 


  Review Request #14273
  —
  Created Dec. 16, 2024 and submitted  — Latest diff uploaded 

 


















 

  

   Information

  





 
 

  chipx86
 









 
 

  Djblets
 









 
 

  release-5.x
 









 
 

  
 









 
 

  
 






 




 

  

   Reviewers

  





 
 

  djblets
 









 
 

  
 






 








 





  


 
 

  
This adds typing throughout ConditionsWidget, and fixes some issues

that this unveiled. We had typing assumptions, potential unbound

variables, and bad logic when choices or operators were None.


This is in preparation for some upcoming work on the widget for better

extensibility.

 








  


 
 

  
Unit tests pass.

 







 









 





  








 




 







   

    
    
Diff Revision 1


This is not the most recent revision of the diff. The latest diff is revision 2. See what's changed.

    

 

 

 

 
orig
1
2

 



    


    

      
Commits

      

 

 

  
   First
   Last
  
  Summary
  ID
  Author
 



 
  
   
  
  
   
  
 
 
  
   
    

     Add typing for ConditionsWidget.
     
This adds typing throughout `ConditionsWidget`, and fixes some issues
that this unveiled. We had typing assumptions, potential unbound
variables, and bad logic when choices or operators were `None`.

This is in preparation for some upcoming work on the widget for better
extensibility.

    

   
  		
  018751b9d89de50f5b811bc08bf0f90b8474ea2c
  Christian Hammond
 




    


    
    

   

  

 









 

  

   
    

     
      
      djblets/conditions/values.py
     
    

   
  

 



 

  

   
    

     
      
      djblets/forms/widgets.py
     
    

   
  

 










     

    

   

  

  

   
   Loading...