This change has been marked as completed.

Describe the completed change (optional):

Pushed to release-5.x (e3fbd62)

Summary

Add typing for ConditionsWidget.

Review Request #14273 — Created Dec. 16, 2024 and submitted 2 months, 2 weeks ago

Information

Owner

chipx86*

Repository

Djblets

Branch

release-5.x

Bugs

Depends On

Reviewers

Groups

djblets

People

Description*

This adds typing throughout ConditionsWidget, and fixes some issues
that this unveiled. We had typing assumptions, potential unbound
variables, and bad logic when choices or operators were None.

This is in preparation for some upcoming work on the widget for better
extensibility.

Testing Done

Unit tests pass.

Commits

Summary	ID
Add typing for ConditionsWidget. This adds typing throughout `ConditionsWidget`, and fixes some issues that this unveiled. We had typing assumptions, potential unbound variables, and bad logic when choices or operators were `None`. This is in preparation for some upcoming work on the widget for better extensibility.	d34b4df8e70b9085ef74d428f360b891f7397e93

Issues

Description	From	Last Updated
This should be documented with a "Version Changed" in the method docstring.	maubin	3 months, 2 weeks ago
There are no open issues

flake8 passed.

JSHint passed.

Ship it!

djblets/forms/widgets.py (Diff revision 1)
The issue has been resolved. Show all issues
```
This should be documented with a "Version Changed" in the method docstring.
```

Change Summary:

Documented the new keyword-only arguments requirement.

Commits:

	Summary	ID
	Add typing for ConditionsWidget. This adds typing throughout `ConditionsWidget`, and fixes some issues that this unveiled. We had typing assumptions, potential unbound variables, and bad logic when choices or operators were `None`. This is in preparation for some upcoming work on the widget for better extensibility.	018751b9d89de50f5b811bc08bf0f90b8474ea2c
	Add typing for ConditionsWidget. This adds typing throughout `ConditionsWidget`, and fixes some issues that this unveiled. We had typing assumptions, potential unbound variables, and bad logic when choices or operators were `None`. This is in preparation for some upcoming work on the widget for better extensibility.	d34b4df8e70b9085ef74d428f360b891f7397e93

Diff:

Revision 2 (+384 -174)

Show changes

	djblets/conditions/values.py
	djblets/forms/widgets.py

Checks run (2 succeeded)

flake8 passed.

JSHint passed.

Ship it!

```
Ship It!
```

Status:: Completed
Change Summary:: Pushed to release-5.x (e3fbd62)

djblets/forms/widgets.py (Diff revision 1)