Support ConditionChoices instances in ConditionsField and add typing.
Review Request #14272 — Created Dec. 15, 2024 and updated
ConditionsField
claimed support for taking aConditionChoices
class
or a callable returning the class, but not an instance. We have call
sites that passed in a class accordingly. The problem with prioritizing
classes is that there's no ability for code to register choices into a
ConditionChoices
after construction (say, for extensions).In practice, this field supported instances just fine, and we even had
unit tests for it, but we now document this explicitly (fixing class
names in the process).The field has also been updated with typing, signature matches, and
some code cleanup.
Unit tests pass.
Summary | ID |
---|---|
5477edf02df93762c2f04e3dc9e0b1a29d66878a |
Description | From | Last Updated |
---|---|---|
It says "may not" here when it should only say "may". |
maubin |