Support ConditionChoices instances in ConditionsField and add typing.
Review Request #14272 — Created Dec. 15, 2024 and submitted
ConditionsField
claimed support for taking aConditionChoices
class
or a callable returning the class, but not an instance. We have call
sites that passed in a class accordingly. The problem with prioritizing
classes is that there's no ability for code to register choices into a
ConditionChoices
after construction (say, for extensions).In practice, this field supported instances just fine, and we even had
unit tests for it, but we now document this explicitly (fixing class
names in the process).The field has also been updated with typing, signature matches, and
some code cleanup.
Unit tests pass.
- Change Summary:
-
Fixed a typo in a docstring.
- Commits:
-
Summary ID 5477edf02df93762c2f04e3dc9e0b1a29d66878a 70b5cdd72f026a26370b60c2b005241b15480795 - Diff:
-
Revision 2 (+156 -56)
Checks run (2 succeeded)
flake8
passed.
JSHint
passed.