Summary

Protect against uninitialized variable or None value in two error cases in post-review 0.2RC1

Review Request #1427 — Created Feb. 22, 2010 and submitted — Latest diff uploaded Feb. 22, 2010, 7:47 a.m.

Information

Owner

lonico

Repository

RBTools

Branch

Bugs

Depends On

Reviewers

Groups

rbtools, reviewboard

People

Description

Line 128:  'err' in self.rsp  would trigger "TypeError: argument of type 'NoneType' is not iterable"  if rsp in None

Line 419: rsp is not initialized but is used at lines 427 and 432 (fall through).    I also moved the last debug message into an else: under try: as a Review is not created in the fall through case.

Testing Done

Verified both error cases.  Verified that a review request is correctly updated if --diff-file option is used with a changenum but no review id.