Summary

Add typing for conditions.

Review Request #14267 — Created Dec. 12, 2024 and submitted Feb. 14, 2025, 2:06 a.m.

Information

Owner

chipx86

Repository

Djblets

Branch

release-5.x

Bugs

Depends On

~~14266~~

Blocks

14268

Reviewers

Groups

djblets

People

Description

This adds type hints for Condition and ConditionSet, along with new
TypedDicts for the serialized data. Documentation has also been
updated for all the instance state.

There's room for further improvement here, notably using enums for
ConditionSet modes. That's outside the scope of this change.

Testing Done

Unit tests pass.

Commits

Summary	ID
Add typing for conditions. This adds type hints for `Condition` and `ConditionSet`, along with new `TypedDict`s for the serialized data. Documentation has also been updated for all the instance state. There's room for further improvement here, notably using enums for `ConditionSet` modes. That's outside the scope of this change.	9da76452def0309cadf6115f5b875e544cd10e26

Issues

Description	From	Last Updated
'typing.Dict' imported but unused Column: 1 Error code: F401	reviewbot	Dec. 12, 2024, 7:46 a.m.

flake8 failed.

JSHint passed.

flake8

djblets/conditions/conditions.py (Diff revision 1)
The issue has been resolved. Show all issues
```
'typing.Dict' imported but unused

Column: 1
Error code: F401
```

Ship it!

```
Ship It!
```

Ship it!

```
Ship It!
```

Status:: Completed
Change Summary:: Pushed to release-5.x (400bee1)