• 
      

    Add typing for condition choices.

    Review Request #14266 — Created Dec. 12, 2024 and submitted

    Information

    Djblets
    release-5.x

    Reviewers

    This introduces typing for BaseConditionChoice and all subclasses.
    All class attributes are clearly typed, as are instance variables.

    This is a pretty straight-forward change. However, there are some issues
    with the current design that prevents us from correctly typing the
    default_value_field. In some cases, we set this as an attribute, and
    in others as a function. That will need to be cleaned up as a separate
    change.

    Unit tests pass.

    Summary ID
    Add typing for condition choices.
    This introduces typing for `BaseConditionChoice` and all subclasses. All class attributes are clearly typed, as are instance variables. This is a pretty straight-forward change. However, there are some issues with the current design that prevents us from correctly typing the `default_value_field`. In some cases, we set this as an attribute, and in others as a function. That will need to be cleaned up as a separate change.
    e392163d34c844edcf80dba6cd3eeaa044452a55
    david
    1. Ship It!
    2. 
        
    maubin
    1. Ship It!
    2. 
        
    chipx86
    Review request changed
    Status:
    Completed
    Change Summary:
    Pushed to release-5.x (6be9376)