Fix an error with file attachment comments.

 






 

 


  Review Request #14259
  —
  Created Dec. 4, 2024 and submitted  — Latest diff uploaded 

 


















 

  

   Information

  





 
 

  david
 









 
 

  Review Board
 









 
 

  release-7.x
 









 
 

  
 









 
 

  
 






 




 

  

   Reviewers

  





 
 

  reviewboard
 









 
 

  
 






 








 





  


 
 

  
I ran into an error with the file attachment comments API where we were

trying to serialize the thumbnail HTML, but mark_safe had been

incorrectly moved into a TYPE_CHECKING block. This change fixes that.

 








  


 
 

  
Was able to fetch file attachment comments with thumbnail HTML via the

API.

 







 









 





  








 




 







   

    
    
Diff Revision 1 (Latest)



    

    


    

      
Commits

      

 

 

  
   First
   Last
  
  Summary
  ID
  Author
 



 
  
   
  
  
   
  
 
 
  
   
    

     Fix an error with file attachment comments.
     
I ran into an error with the file attachment comments API where we were
trying to serialize the thumbnail HTML, but `mark_safe` had been
incorrectly moved into a `TYPE_CHECKING` block. This change fixes that.

Testing Done:
Was able to fetch file attachment comments with thumbnail HTML via the
API.

    

   
  		
  095af6c466f12e00e0255c86e04bd62bb5fef9f2
  David Trowbridge
 




    


    
    

   

  

 









 

  

   
    

     
      
      reviewboard/reviews/models/file_attachment_comment.py
     
    

   
  

 










     

    

   

  

  

   
   Loading...