Summary

Add typing and modernize docs for resource subclasses.

Review Request #14245 — Created Nov. 13, 2024 and updated Nov. 13, 2024, 9:20 a.m.

Information

Owner

david

Repository

RBTools

Branch

master

Bugs

Depends On

Reviewers

Groups

rbtools

People

Description

This change modernizes the existing resource subclasses, fixing up
typing and documentation. This also adds any missing item or list
resource subclasses to match the ones we have.

Testing Done


Ran unit tests.
Used the RBTools API for various tests.

Commits

Summary	ID
Add typing and modernize docs for resource subclasses. This change modernizes the existing resource subclasses, fixing up typing and documentation. This also adds any missing item or list resource subclasses to match the ones we have.	3529401517bee7583803a6045f5bb861a38a85b0

Issues

Description	From	Last Updated
multiple spaces after keyword Column: 36 Error code: E271	reviewbot	Nov. 13, 2024, 9:20 a.m.
missing whitespace around operator Column: 6 Error code: E225	reviewbot	Nov. 13, 2024, 9:20 a.m.

flake8 failed.

JSHint passed.

flake8

rbtools/api/resource/draft_diff_commit.py (Diff revision 1)
The issue has been dropped. Show all issues
```
multiple spaces after keyword

Column: 36
Error code: E271
```
rbtools/api/resource/review_request.py (Diff revision 1)
The issue has been dropped. Show all issues
```
missing whitespace around operator

Column: 6
Error code: E225
```

Commits:

	Summary	ID
	Add typing and modernize docs for resource subclasses. This change modernizes the existing resource subclasses, fixing up typing and documentation. This also adds any missing item or list resource subclasses to match the ones we have.	6d95d09c215e540e170f60d6b693ce4bc5996e5b
	Add typing and modernize docs for resource subclasses. This change modernizes the existing resource subclasses, fixing up typing and documentation. This also adds any missing item or list resource subclasses to match the ones we have.	3529401517bee7583803a6045f5bb861a38a85b0

Diff:

Revision 2 (+1094 -276)

Show changes

	pyproject.toml
	rbtools/api/resource/__init__.py
	rbtools/api/resource/diff.py
	rbtools/api/resource/diff_commit.py
	rbtools/api/resource/diff_file_attachment.py
	rbtools/api/resource/draft_diff.py
	rbtools/api/resource/draft_diff_commit.py
	rbtools/api/resource/draft_file_attachment.py
	9 more

Checks run (2 succeeded)

flake8 passed.

JSHint passed.