Summary

Fix crashes that could occur when detecting file mimetypes.

Review Request #14229 — Created Nov. 5, 2024 and submitted Nov. 8, 2024, 6:26 p.m.

Information

Owner

david

Repository

RBTools

Branch

release-5.x

Bugs

Depends On

Reviewers

Groups

rbtools

People

Description

This change mirrors a similar fix that we recently did for Review Board.
This fixes two issues with RBTools' MIME-type detection:

Some versions of Python break if you try to close an already-closed
pipe, and this had happened on one customer's machine. file may
close the input stream once it's read enough data to make a
determination, and our attempt to close would then fail.
Errors executing or communicating with file would crash.

Testing Done

Ran unit tests.

Commits

Summary	ID
Fix crashes that could occur when detecting file mimetypes. This change mirrors a similar fix that we recently did for Review Board. This fixes two issues with RBTools' MIME-type detection: 1. Some versions of Python break if you try to close an already-closed pipe, and this had happened on one customer's machine. `file` may close the input stream once it's read enough data to make a determination, and our attempt to close would then fail. 3. Errors executing or communicating with `file` would crash, and even if caught higher up it'd leave the uploaded file truncated (the file pointer wouldn't be at 0). Testing Done: Ran unit tests.	8194c13c7aa42077a8f71dbf57930a267a6d15b3

Summary

Fix crashes that could occur when detecting file mimetypes.

This change mirrors a similar fix that we recently did for Review Board. This fixes two issues with RBTools' MIME-type detection: 1. Some versions of Python break if you try to close an already-closed pipe, and this had happened on one customer's machine. `file` may close the input stream once it's read enough data to make a determination, and our attempt to close would then fail. 3. Errors executing or communicating with `file` would crash, and even if caught higher up it'd leave the uploaded file truncated (the file pointer wouldn't be at 0). Testing Done: Ran unit tests.

8194c13c7aa42077a8f71dbf57930a267a6d15b3

flake8 passed.

JSHint passed.

Description:: This change mirrors a similar fix that we recently did for Review Board.
This fixes two issues with RBTools' MIME-type detection:

Some versions of Python break if you try to close an already-closed
pipe, and this had happened on one customer's machine. file may
close the input stream once it's read enough data to make a
determination, and our attempt to close would then fail.

~

Errors executing or communicating with file would crash, and even
if caught higher up it'd leave the uploaded file truncated (the file
pointer wouldn't be at 0).

~

Errors executing or communicating with file would crash.

Ship it!

```
Ship It!
```

Ship it!

```
Ship It!
```

Status:: Completed
Change Summary:: Pushed to release-5.x (bc2d7a7)

		This change mirrors a similar fix that we recently did for Review Board.
		This fixes two issues with RBTools' MIME-type detection:

		Some versions of Python break if you try to close an already-closed pipe, and this had happened on one customer's machine. `file` may close the input stream once it's read enough data to make a determination, and our attempt to close would then fail.
~		Errors executing or communicating with `file` would crash, and even if caught higher up it'd leave the uploaded file truncated (the file pointer wouldn't be at 0).
	~	Errors executing or communicating with `file` would crash.