• 
      

    Fix issues with large images in the diff viewer.

    Review Request #14228 — Created Nov. 5, 2024 and submitted

    Information

    Review Board
    release-7.x

    Reviewers

    This fixes a couple issues that appear when images in the diff viewer
    had a larger width than their container. The header that contained the
    zoom controls would match the width of the image, so the zoom controls
    would be cut off and inacessible. Secondly, there was no scroll bar, so
    you wouldn't be able to see the full image when it overflowed in the
    container. These issues only happened for large images in the diff
    viewer, images in their individual review UI page were fine.
    • Looked at images in the diff viewer (smaller than the container and
      bigger).
    • Looked code diffs in the diff viewer and saw that they looked the same
      as before.
    • Looked at images in their review UI and made sure there were no issues.
    Summary ID
    Fix issues with large images in the diff viewer.
    This fixes a couple issues that appear when images in the diff viewer had a larger width than their container. The header that contained the zoom controls would match the width of the image, so the zoom controls would be cut off and inacessible. Secondly, there was no scroll bar, so you wouldn't be able to see the full image when it overflowed in the container. These issues only happened for large images in the diff viewer, images in their individual review UI page were fine.
    3134c7f92f9ce6584c47f088647170f1d006706c
    chipx86
    1. Ship It!
    2. 
        
    david
    1. Ship It!
    2. 
        
    maubin
    Review request changed
    Status:
    Completed
    Change Summary:
    Pushed to release-7.x (73f2469)