Clean up ReviewBoardServer initialization.
Review Request #14222 — Created Nov. 2, 2024 and updated — Latest diff uploaded
ReviewBoardServer
performs several actions as part of its
initialization:
- URL normalization and parsing
- Cookie loading and setting
- Setting a default agent
- Configuring authentication
- Configuring SSL
- Setting HTTP handlers
- Adding headers
A lot of this code was scattered, disorganized. This change attempts to
organize this and document the sections to help keep things clean. It
also removes redundant attribute acceses and updates some code for
readability.
One notable change is that the URL parsing and normalization has largely
moved to a new _normalize_url_parts()
method, which has also been
expanded for some upcoming needs for strict domain cookies.
Unit tests passed.
Successfully posted this change for review.