Clean up ReviewBoardServer initialization.

Review Request #14222 — Created Nov. 2, 2024 and submitted

Information

RBTools
release-5.x

Reviewers

ReviewBoardServer performs several actions as part of its
initialization:

  • URL normalization and parsing
  • Cookie loading and setting
  • Setting a default agent
  • Configuring authentication
  • Configuring SSL
  • Setting HTTP handlers
  • Adding headers

A lot of this code was scattered, disorganized. This change attempts to
organize this and document the sections to help keep things clean. It
also removes redundant attribute acceses and updates some code for
readability.

One notable change is that the URL parsing and normalization has largely
moved to a new _normalize_url_parts() method, which has also been
expanded for some upcoming needs for strict domain cookies.

Unit tests passed.

Successfully posted this change for review.

Summary ID
Clean up ReviewBoardServer initialization.
`ReviewBoardServer` performs several actions as part of its initialization: * URL normalization and parsing * Cookie loading and setting * Setting a default agent * Configuring authentication * Configuring SSL * Setting HTTP handlers * Adding headers A lot of this code was scattered, disorganized. This change attempts to organize this and document the sections to help keep things clean. It also removes redundant attribute acceses and updates some code for readability. One notable change is that the URL parsing and normalization has largely moved to a new `_normalize_url_parts()` method, which has also been expanded for some upcoming needs for strict domain cookies.
9d47d52d5b0ec03643874d634f0c8a3ca59f5d9d
maubin
  1. Ship It!
  2. 
      
david
  1. Ship It!
  2. 
      
chipx86
Review request changed
Status:
Completed
Change Summary:
Pushed to release-5.x (5b561af)