Do some cleanup and typing in RBTools config/options code.

Review Request #14218 — Created Oct. 30, 2024 and submitted

Information

RBTools
release-5.x

Reviewers

This change does some cleanup, typing, and general modernization in
preparation for allowing config namespacing.

Ran unit tests.

Summary ID
Do some cleanup and typing in RBTools config/options code.
This change does some cleanup, typing, and general modernization in preparation for allowing config namespacing. Testing Done: Ran unit tests.
5cef442d35f67e407bafb19bf23f08c200e28405
Description From Last Updated

Missing a trailing period.

chipx86chipx86

We should use Sequence here (any time we don't need to modify the list).

chipx86chipx86

This should probably also be Sequence. There are other candidates in this change (notably argv in places) but I don't …

chipx86chipx86
david
maubin
  1. Ship It!
  2. 
      
chipx86
  1. 
      
  2. rbtools/commands/base/commands.py (Diff revision 2)
     
     
    Show all issues

    Missing a trailing period.

  3. rbtools/utils/filesystem.py (Diff revision 2)
     
     
    Show all issues

    We should use Sequence here (any time we don't need to modify the list).

  4. rbtools/utils/filesystem.py (Diff revision 2)
     
     
    Show all issues

    This should probably also be Sequence.

    There are other candidates in this change (notably argv in places) but I don't know how complex those may end up becoming.

  5. 
      
david
chipx86
  1. Ship It!
  2. 
      
david
Review request changed
Status:
Completed
Change Summary:
Pushed to release-5.x (22792e6)