Summary

Do some cleanup and typing in RBTools config/options code.

Review Request #14218 — Created Oct. 30, 2024 and submitted Nov. 6, 2024, 4:27 p.m.

Information

Owner

david

Repository

RBTools

Branch

release-5.x

Bugs

Depends On

Reviewers

Groups

rbtools

People

Description

This change does some cleanup, typing, and general modernization in
preparation for allowing config namespacing.

Testing Done

Ran unit tests.

Commits

Summary	ID
Do some cleanup and typing in RBTools config/options code. This change does some cleanup, typing, and general modernization in preparation for allowing config namespacing. Testing Done: Ran unit tests.	5cef442d35f67e407bafb19bf23f08c200e28405

Issues

Description	From	Last Updated
Missing a trailing period.	chipx86	Nov. 1, 2024, 2:42 p.m.
We should use Sequence here (any time we don't need to modify the list).	chipx86	Nov. 1, 2024, 3:01 p.m.
This should probably also be Sequence. There are other candidates in this change (notably argv in places) but I don't …	chipx86	Nov. 1, 2024, 3:14 p.m.

flake8 passed.

JSHint passed.

Change Summary:

Increase scope of changes somewhat.

Summary:

Do some cleanup of typing in RBTools config code.

Do some cleanup and typing in RBTools config/options code.

Description:

~		The config code is relatively modern, but it did have a few things that
~		were being highlighted for me by my tooling. This change cleans those up
	~	This change does some cleanup, typing, and general modernization in
	~	preparation for allowing config namespacing.
-		as I start to poke at config namespacing.

Commits:

	Summary	ID
	Do some cleanup of typing in RBTools config code. The config code is relatively modern, but it did have a few things that were being highlighted for me by my tooling. This change cleans those up as I start to poke at config namespacing. Testing Done: Ran unit tests.	0268613ebb93caff3f73acc2dbd7d989d9119eac
	Do some cleanup and typing in RBTools config/options code. This change does some cleanup, typing, and general modernization in preparation for allowing config namespacing. Testing Done: Ran unit tests.	c8fe039ccac62b4aee9a0bf19449b578ddd4cd89

Diff:

Revision 2 (+418 -276)

Show changes

	rbtools/clients/__init__.py
	rbtools/clients/base/repository.py
	rbtools/commands/base/commands.py
	rbtools/commands/base/options.py
	rbtools/config/config.py
	rbtools/config/loader.py
	rbtools/config/tests/test_config.py
	rbtools/utils/filesystem.py

Checks run (2 succeeded)

flake8 passed.

JSHint passed.

Ship it!

```
Ship It!
```

rbtools/commands/base/commands.py (Diff revision 2)
The issue has been resolved. Show all issues
```
Missing a trailing period.
```
rbtools/utils/filesystem.py (Diff revision 2)
The issue has been resolved. Show all issues
```
We should use Sequence here (any time we don't need to modify the list).
```

rbtools/utils/filesystem.py (Diff revision 2)

The issue has been resolved. Show all issues

This should probably also be Sequence.

There are other candidates in this change (notably argv in places) but I don't know how complex those may end up becoming.

Commits:

	Summary	ID
	Do some cleanup and typing in RBTools config/options code. This change does some cleanup, typing, and general modernization in preparation for allowing config namespacing. Testing Done: Ran unit tests.	c8fe039ccac62b4aee9a0bf19449b578ddd4cd89
	Do some cleanup and typing in RBTools config/options code. This change does some cleanup, typing, and general modernization in preparation for allowing config namespacing. Testing Done: Ran unit tests.	5cef442d35f67e407bafb19bf23f08c200e28405

Diff:

Revision 3 (+422 -276)

Show changes

	rbtools/clients/__init__.py
	rbtools/clients/base/repository.py
	rbtools/commands/base/commands.py
	rbtools/commands/base/options.py
	rbtools/config/config.py
	rbtools/config/loader.py
	rbtools/config/tests/test_config.py
	rbtools/utils/filesystem.py

Checks run (2 succeeded)

flake8 passed.

JSHint passed.

Ship it!

```
Ship It!
```

Status:: Completed
Change Summary:: Pushed to release-5.x (22792e6)