Fix type of 'p' argument in SVN patching implementation.

 






 

 


  Review Request #14217
  —
  Created Oct. 29, 2024 and submitted  — Latest diff uploaded 

 


















 

  

   Information

  





 
 

  david
 









 
 

  RBTools
 









 
 

  release-5.x
 









 
 

  
 









 
 

  
 






 




 

  

   Reviewers

  





 
 

  rbtools
 









 
 

  
 






 








 





  


 
 

  
The SVN implementation for apply_patch was trying to do an integer

comparison on the --px value, which was typed as a string. This change

fixes it so when a p-number is user supplied, we convert it to an int as

necessary.

 








  


 
 

  
Ran unit tests (including fixed unit test for the p argument).

 







 









 





  








 




 







   

    
    
Diff Revision 2 (Latest)



    

 

 

 

 
orig
1
2

 



    


    

      
Commits

      

 

 

  
   First
   Last
  
  Summary
  ID
  Author
 



 
  
   
  
  
   
  
 
 
  
   
    

     Fix type of 'p' argument in SVN patching implementation.
     
The SVN implementation for `apply_patch` was trying to do an integer
comparison on the `--px` value, which was typed as a string. This change
fixes it so when a p-number is user supplied, we convert it to an int as
necessary.

Testing Done:
Ran unit tests (including fixed unit test for the `p` argument).

    

   
  		
  f1a316a0fab1ce4c0c89aefa9c6d3bb827388169
  David Trowbridge
 




    


    
    

   

  

 









 

  

   
    

     
      
      rbtools/clients/svn.py
     
    

   
  

 



 

  

   
    

     
      
      rbtools/clients/tests/test_svn.py
     
    

   
  

 










     

    

   

  

  

   
   Loading...