Summary

Fix type of 'p' argument in SVN patching implementation.

Review Request #14217 — Created Oct. 29, 2024 and submitted Oct. 29, 2024, 10:14 p.m.

Information

Owner

david

Repository

RBTools

Branch

release-5.x

Bugs

Depends On

Reviewers

Groups

rbtools

People

Description

The SVN implementation for apply_patch was trying to do an integer
comparison on the --px value, which was typed as a string. This change
fixes it so when a p-number is user supplied, we convert it to an int as
necessary.

Testing Done

Ran unit tests (including fixed unit test for the p argument).

Commits

Summary	ID
Fix type of 'p' argument in SVN patching implementation. The SVN implementation for `apply_patch` was trying to do an integer comparison on the `--px` value, which was typed as a string. This change fixes it so when a p-number is user supplied, we convert it to an int as necessary. Testing Done: Ran unit tests (including fixed unit test for the `p` argument).	f1a316a0fab1ce4c0c89aefa9c6d3bb827388169

Issues

Description	From	Last Updated
Let's wrap this in a try/except and gracefully handle any non-int p.	chipx86	Oct. 29, 2024, 9:58 p.m.
local variable 'e' is assigned to but never used Column: 13 Error code: F841	reviewbot	Oct. 29, 2024, 10:07 p.m.

flake8 passed.

JSHint passed.

rbtools/clients/svn.py (Diff revision 1)
The issue has been resolved. Show all issues
```
Let's wrap this in a try/except and gracefully handle any non-int p.
```

Change Summary:

Handle ValueError on converting p value

Commits:

	Summary	ID
	Fix type of 'p' argument in SVN patching implementation. The SVN implementation for `apply_patch` was trying to do an integer comparison on the `--px` value, which was typed as a string. This change fixes it so when a p-number is user supplied, we convert it to an int as necessary. Testing Done: Ran unit tests (including fixed unit test for the `p` argument).	0a1b7fd325e0997b2d8b408b7baa01c88c6d831c
	Fix type of 'p' argument in SVN patching implementation. The SVN implementation for `apply_patch` was trying to do an integer comparison on the `--px` value, which was typed as a string. This change fixes it so when a p-number is user supplied, we convert it to an int as necessary. Testing Done: Ran unit tests (including fixed unit test for the `p` argument).	f1a316a0fab1ce4c0c89aefa9c6d3bb827388169

Diff:

Revision 2 (+56 -26)

Show changes

	rbtools/clients/svn.py
	rbtools/clients/tests/test_svn.py

Checks run (1 failed, 1 succeeded)

flake8 failed.

JSHint passed.

flake8

rbtools/clients/svn.py (Diff revision 2)

The issue has been resolved. Show all issues

local variable 'e' is assigned to but never used

Column: 13
Error code: F841

Ship it!

```
Ship It!
```

Status:: Completed
Change Summary:: Pushed to release-5.x (c73c942)