Fix migration of already-migrated SCMTool IDs in integration conditions.

Review Request #14216 — Created Oct. 28, 2024 and submitted

Information

Review Board
release-7.x

Reviewers

During upgrade, we attempt to convert any SCMTool primary key IDs in
conditions found in integration configurations. If we're dealing with
any partially-migrated conditions, we could end up crashing, since our
assumption that an entry is a primary key will fail.

We now safeguard against this when collecting IDs for the migration map
and then again when we update the values, allowing non-integer IDs to
remain as-is.

Unit tests passed.

Verified this fixed an issue I encountered in some partially-migrated state.

Summary ID
Fix migration of already-migrated SCMTool IDs in integration conditions.
During upgrade, we attempt to convert any SCMTool primary key IDs in conditions found in integration configurations. If we're dealing with any partially-migrated conditions, we could end up crashing, since our assumption that an entry is a primary key will fail. We now safeguard against this when collecting IDs for the migration map and then again when we update the values, allowing non-integer IDs to remain as-is.
e455387a5be528d535444a6d596ea646fb37fea4
david
  1. Ship It!
  2. 
      
maubin
  1. Ship It!
  2. 
      
chipx86
Review request changed
Status:
Completed
Change Summary:
Pushed to release-7.x (5e6cd58)