Fix migration of legacy SCMTools.

Review Request #14215 — Created Oct. 28, 2024 and submitted — Latest diff uploaded

Information

Review Board
release-7.x

Reviewers

When we migrate a database, we migrate legacy SCMTool entrypoints,
creating a map of their class paths to names. Unfortunately, this code
regressed when we moved to the modern importlib-based entrypoints, as we
were accessing old attribute names.

This is a simple change that switches to the modern attributes, fixing
migration.

Verified this fixed a migration of an old database that had some
entrypoint-based SCMTools.

Changes between revision 1 and 2

orig
1
2

Commits

Summary ID Author
Fix migration of legacy SCMTools.
When we migrate a database, we migrate legacy SCMTool entrypoints, creating a map of their class paths to names. Unfortunately, this code regressed when we moved to the modern importlib-based entrypoints, as we were accessing old attribute names. This is a simple change that switches to the modern attributes, fixing migration.
b230055429ebfc90eb28d1afe3b87419da5e0868 Christian Hammond
Fix migration of legacy SCMTools.
When we migrate a database, we migrate legacy SCMTool entrypoints, creating a map of their class paths to names. Unfortunately, this code regressed when we moved to the modern importlib-based entrypoints, as we were accessing old attribute names. This is a simple change that switches to the modern attributes, fixing migration.
53640be77502528312bf679c00d2efc76448c02f Christian Hammond
reviewboard/scmtools/core.py
Loading...