• 
      

    Always consider new migration-aware apps when evolving.

    Review Request #14214 — Created Oct. 28, 2024 and submitted

    Information

    Django Evolution
    release-2.x

    Reviewers

    The code for building the migration graph wasn't considering
    migration-aware apps that didn't already exist in the database. This
    could prevent some migrations from applying or being considered for
    custom evolutions.

    The cause was a small logic error where we tried to avoid working with
    the signature if it didn't exist, but we checked this too early and
    failed to put the app in the list of migration-aware apps. The logic has
    moved to the appropriate conditional.

    All unit tests passed.

    Verified that this fixed an issue with an newly-added app not being
    considered for migration.

    Summary ID
    Always consider new migration-aware apps when evolving.
    The code for building the migration graph wasn't considering migration-aware apps that didn't already exist in the database. This could prevent some migrations from applying or being considered for custom evolutions. The cause was a small logic error where we tried to avoid working with the signature if it didn't exist, but we checked this too early and failed to put the app in the list of migration-aware apps. The logic has moved to the appropriate conditional.
    0f9dc9fe783903bd379555d2c24b349fedc2d31d
    david
    1. Ship It!
    2. 
        
    chipx86
    Review request changed
    Status:
    Completed
    Change Summary:
    Pushed to release-2.x (1cdbe56)