Summary

Add support for RENAMED_FIELD_TYPES in the legacy pickler.

Review Request #14208 — Created Oct. 17, 2024 and updated Oct. 18, 2024, 8:23 a.m.

Information

Owner

chipx86

Repository

Django Evolution

Branch

release-2.x

Bugs

Depends On

Reviewers

Groups

django-evolution

People

Description

Django Evolution's modern JSON-based serializer gained support for
RENAMED_FIELD_TYPES, which allowed codebases to map legacy field
classes to new ones. However, the legacy pickle-based deserializer
didn't have this capability, meaning that older codebases would still
fail to find renamed modules.

This change adds support for RENAMED_FIELD_TYPES in the legacy
unpickler. This unpickler already hard-codes support for some legacy
types, making this pretty straightforward.

Testing Done

Tested an upgrade with the legacy unpickler referencing a module we
wanted to rename. Verified the upgrade worked successfully.

Commits

Summary	ID
Add support for RENAMED_FIELD_TYPES in the legacy pickler. Django Evolution's modern JSON-based serializer gained support for `RENAMED_FIELD_TYPES`, which allowed codebases to map legacy field classes to new ones. However, the legacy pickle-based deserializer didn't have this capability, meaning that older codebases would still fail to find renamed modules. This change adds support for `RENAMED_FIELD_TYPES` in the legacy unpickler. This unpickler already hard-codes support for some legacy types, making this pretty straightforward.	20159690070da6caa01c43475c776c21aceee3f4

Summary

Add support for RENAMED_FIELD_TYPES in the legacy pickler.

Django Evolution's modern JSON-based serializer gained support for `RENAMED_FIELD_TYPES`, which allowed codebases to map legacy field classes to new ones. However, the legacy pickle-based deserializer didn't have this capability, meaning that older codebases would still fail to find renamed modules. This change adds support for `RENAMED_FIELD_TYPES` in the legacy unpickler. This unpickler already hard-codes support for some legacy types, making this pretty straightforward.

20159690070da6caa01c43475c776c21aceee3f4

Issues

Description	From	Last Updated
Oops just noticed this as I clicked Ship It for my last review, these two imports should be flipped (M …	maubin	Oct. 18, 2024, 8:09 a.m.

flake8 passed.

JSHint passed.

Ship it!

```
Ship It!
```

Ship it!

```
Ship It!
```

Ship it!

django_evolution/compat/picklers.py (Diff revision 1)

The issue has been dropped. Show all issues

Oops just noticed this as I clicked Ship It for my last review, these two imports should be flipped (M before N)

maubin Oct. 18, 2024, 8:09 a.m.

Nvm, realizing this is because the first import is shallower. Disregard this.

david Oct. 18, 2024, 8:23 a.m.

We actually do it completely lexigraphically, so your comment was right.