• 
      

    Split file attachment tests into multiple modules.

    Review Request #14196 — Created Oct. 10, 2024 and submitted

    Information

    Review Board
    release-7.x

    Reviewers

    All of our file attachment tests were living in a single module, making
    it annoying to maintain. This change splits this up into several
    modules, one per class or purpose.

    We did have some tests specific to the review request diff viewer
    fragment code, which was living in here. These tests have moved to the
    module responsible for this code's tests.

    No code within the tests have changed. This means that they're largely
    using older style and doc guidelines. There are currently no plans to
    redo any of this.

    All unit tests pass.

    Summary ID
    Split file attachment tests into multiple modules.
    All of our file attachment tests were living in a single module, making it annoying to maintain. This change splits this up into several modules, one per class or purpose. We did have some tests specific to the review request diff viewer fragment code, which was living in here. These tests have moved to the module responsible for this code's tests.
    adb66274fa7d542c43285c334a5fcf412e114fec
    Description From Last Updated

    Could add a docstring to reviewboard/attachments/tests/__init__.py

    maubinmaubin
    david
    1. Ship It!
    2. 
        
    maubin
    1. 
        
    2. Show all issues

      Could add a docstring to reviewboard/attachments/tests/__init__.py

    3. 
        
    chipx86
    Review request changed
    Status:
    Completed
    Change Summary:
    Pushed to release-7.x (347f17b)