Use Ink colours for flags and comments.

Review Request #14195 — Created Oct. 10, 2024 and submitted — Latest diff uploaded

Information

Review Board
release-7.x

Reviewers

This change adds new --rb-p-flag-draft-* and --rb-p-flag-published-*
definitions to our standard colour palette. These should be used for flags
that indicate whether an item is a draft or published. The colours either
exactly match the old ones that we used or are very close. We update the
following items to use these new definitions:

  • Comment flags
  • Comment tooltips
  • Image region comments
  • Datagrid draft labels
  • File attachment draft labels

This change also fixes a syntax mistake in the definition for
--rb-theme-rich-text-code-fg, and pulls out a couple variable
definitions for --rb-theme-rich-text-code-bg to make code blocks
in comment tooltips look nicer.

Looked at the comments, datagrid labels and file attachment labels on
darkmode and lightmode.

Diff Revision 4 (Latest)

orig
1
2
3
4

Commits

First Last Summary ID Author
Use Ink colours for flags and comments.
This change adds new `--rb-p-flag-draft-*` and `--rb-p-flag-published-*` definitions to our standard colour palette. These should be used for flags that indicate whether an item is a draft or published. We update the following items to use these new definitions: * Comment flags * Comment tooltips * Image region comments * Datagrid draft labels * File attachment draft labels This change also fixes a syntax mistake in the definition for `--rb-theme-rich-text-code-fg`, and pulls out a couple variable definitions for `--rb-theme-rich-text-code-bg` to fix make code blocks in comment tooltips look nicer.
7011123c35140dda874c1a3e73410ffa9bf58305 Michelle Aubin
reviewboard/static/rb/css/defs.less
reviewboard/static/rb/css/syntax.less
reviewboard/static/rb/css/pages/diffviewer.less
reviewboard/static/rb/css/pages/image-review-ui.less
reviewboard/static/rb/css/pages/reviews.less
reviewboard/static/rb/css/ui/colors.less
reviewboard/static/rb/css/ui/datagrids.less
reviewboard/static/rb/css/ui/review-request/field-state-label.less
Loading...