Use Ink colours for flags and comments.
Review Request #14195 — Created Oct. 10, 2024 and submitted
This change adds new
--rb-p-flag-draft-*
and--rb-p-flag-published-*
definitions to our standard colour palette. These should be used for flags
that indicate whether an item is a draft or published. The colours either
exactly match the old ones that we used or are very close. We update the
following items to use these new definitions:
- Comment flags
- Comment tooltips
- Image region comments
- Datagrid draft labels
- File attachment draft labels
This change also fixes a syntax mistake in the definition for
--rb-theme-rich-text-code-fg
, and pulls out a couple variable
definitions for --rb-theme-rich-text-code-bg
to make code blocks
in comment tooltips look nicer.
Looked at the comments, datagrid labels and file attachment labels on
darkmode and lightmode.
Summary | ID |
---|---|
7011123c35140dda874c1a3e73410ffa9bf58305 |
Description | From | Last Updated |
---|---|---|
We can't redefine these variables to use CSS variables, because it's possible some third party might try to use LESS … |
david | |
We can use var(--ink-u-border-radius-s) here. |
david | |
We can use var(--ink-u-border-thin) here. |
david | |
Instead of 1px can we use var(--ink-u-border-thin)? |
david | |
Can you add a blank line here and before the next section, to preserve the two blankes per groupings of … |
chipx86 | |
We might want to make a variable that defines the border so call sites don't have to worry about the … |
chipx86 |
- Commits:
-
Summary ID 1e6fab7faa914e5e5f1a2c90a747cee58d2fb381 0b9c7eba63627414dae38d4aaed293678f11b71e - Diff:
-
Revision 2 (+114 -68)
Checks run (2 succeeded)
- Commits:
-
Summary ID 0b9c7eba63627414dae38d4aaed293678f11b71e 4f60909a1ccabc5ae41044fa65f3643fb09ee4b3 - Diff:
-
Revision 3 (+120 -74)
Checks run (2 succeeded)
- Commits:
-
Summary ID 4f60909a1ccabc5ae41044fa65f3643fb09ee4b3 7011123c35140dda874c1a3e73410ffa9bf58305 - Diff:
-
Revision 4 (+132 -80)