• 
      

    Fix spurious logging triggered from Trello searches.

    Review Request #14185 — Created Sept. 25, 2024 and submitted

    Information

    rbintegrations
    release-4.x

    Reviewers

    While testing out the Trello integration, I noticed that if I typed in a
    search and then backspaced it out, we'd get errors in the log about
    invalid API requests. The problem is that our selectize-based search
    triggers an API request every time it changes, even when the input is
    emptied out, but the Trello API requires the search text to be at least
    1 character long.

    This change makes it so if the search query is empty, we just directly
    return an empty list to the client instead of trying to make an API
    request to Trello.

    Emptied out my search input and saw that the search results drop-down
    disappeared without any ugly errors being logged on the server.

    Summary ID
    Fix spurious logging triggered from Trello searches.
    While testing out the Trello integration, I noticed that if I typed in a search and then backspaced it out, we'd get errors in the log about invalid API requests. The problem is that our selectize-based search triggers an API request every time it changes, even when the input is emptied out, but the Trello API requires the search text to be at least 1 character long. This change makes it so if the search query is empty, we just directly return an empty list to the client instead of trying to make an API request to Trello. Testing Done: Emptied out my search input and saw that the search results drop-down disappeared without any ugly errors being logged on the server.
    3b54685b6b89abd63210e95114b49725bfcad518
    maubin
    1. Ship It!
    2. 
        
    chipx86
    1. Ship It!
    2. 
        
    david
    Review request changed
    Status:
    Completed
    Change Summary:
    Pushed to release-4.x (a54fba2)