• 
      

    Fix up bad use of CSS variables in configforms.

    Review Request #14177 — Created Sept. 24, 2024 and submitted

    Information

    Djblets
    release-5.x

    Reviewers

    When I made changes to our configforms CSS to use Ink for more things, I
    mistakenly changed several of our LESS variable definitions to use the
    new CSS variables. This works for many things, but crashes if another
    file tries to use LESS operators (such as darken() or simple
    calculations) with them.

    This change reverts the old LESS variables back to their old values, and
    then updates the rules to reference our ink variables directly.

    • Grepped around to make sure we weren't using old variables
      inappropriately (there will be a couple fixes elsewhere)
    • Verified the appearance of configforms pages in Review Board's "My
      Account" and admin integrations list pages.
    Summary ID
    Fix up bad use of CSS variables in configforms.
    When I made changes to our configforms CSS to use Ink for more things, I mistakenly changed several of our LESS variable definitions to use the new CSS variables. This works for many things, but crashes if another file tries to use LESS operators (such as `darken()` or simple calculations) with them. This change reverts the old LESS variables back to their old values, and then updates the rules to reference our ink variables directly. Testing Done: - Grepped around to make sure we weren't using old variables inappropriately (there will be a couple fixes elsewhere) - Verified the appearance of configforms pages in Review Board's "My Account" and admin integrations list pages.
    e2f09a02d1af27c343b415904fa44774fa3c41ce
    maubin
    1. Ship It!
    2. 
        
    chipx86
    1. Ship It!
    2. 
        
    david
    Review request changed
    Status:
    Completed
    Change Summary:
    Pushed to release-5.x (43419b5)