• 
      

    Always use setuptools editable-compat mode.

    Review Request #14170 — Created Sept. 13, 2024 and submitted

    Information

    Djblets
    release-5.x

    Reviewers

    Setuptools has been transitioning away from old path-based pth files for
    editable builds to newer import hooks, but these aren't compatible with
    tools like mypy, pyright, or IDEs. Because of this, there's expected
    to be long-term support for activating a "compat" editable mode, which
    we now opt into using our build backend. This ensures typing for all
    editable builds.

    Tested installing with and without the compat editable mode. In both
    cases, we get an __editable__.Djblets-<version>.pth file in the
    site-packages directory. Previously, that'd contain an import,
    but now it lists a path.

    Summary ID
    Always use setuptools editable-compat mode.
    Setuptools has been transitioning away from old path-based pth files for editable builds to newer import hooks, but these aren't compatible with tools like mypy, pyright, or IDEs. Because of this, there's expected to be long-term support for activating a "compat" editable mode, which we now opt into using our build backend. This ensures typing for all editable builds.
    1ffdc6f68315c970e982a7f799f9f525f4a56cbf
    david
    1. Ship It!
    2. 
        
    chipx86
    Review request changed
    Status:
    Completed
    Change Summary:
    Pushed to release-5.x (f8394a0)